Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more of scalafix #608

Closed
SethTisue opened this issue Sep 21, 2017 · 10 comments
Closed

add more of scalafix #608

SethTisue opened this issue Sep 21, 2017 · 10 comments
Assignees

Comments

@SethTisue
Copy link
Member

SethTisue commented Sep 21, 2017

https://github.com/scalameta/semanticdb-sbt

as per @olafurpg's comment on #605

@SethTisue
Copy link
Member Author

needs a fork to remove coursier and use a newer, dbuild-friendly version of sbt-bintray

SethTisue added a commit to SethTisue/community-build that referenced this issue Sep 23, 2017
SethTisue added a commit to SethTisue/community-build that referenced this issue Sep 23, 2017
SethTisue added a commit to SethTisue/community-build that referenced this issue Sep 23, 2017
@SethTisue
Copy link
Member Author

needs https://github.com/alexarchambault/case-app too (fyi @alexarchambault)

@SethTisue
Copy link
Member Author

SethTisue commented Sep 23, 2017

oh my

[scalafix] [error] **** Missing dependency: the library org.typelevel#paiges-core
  is not provided (in space "default") by any project in this configuration file.

@SethTisue
Copy link
Member Author

well okay, 999 cuts didn't kill me, why not add paiges too? fyi @non @johnynek @coltfred

SethTisue added a commit to SethTisue/community-build that referenced this issue Sep 23, 2017
SethTisue added a commit that referenced this issue Sep 23, 2017
@SethTisue
Copy link
Member Author

c69ea94 has substantial progress: it adds paiges, case-app, and semanticdb-sbt-runtime, and also adds scalafix's cli subproject. it doesn't go all the way to adding the unit subproject.

@SethTisue SethTisue changed the title add semanticdb-sbt-runtime so we can enable scalafix "unit" subproject add more of scalafix Sep 23, 2017
@SethTisue
Copy link
Member Author

I see that unit is defined in an unusual way (novel to me, anyway) that pulls in source directories from subprojects we are attempting to exclude. in our fork, perhaps we just need to remove the lines from build.sbt that refer to subprojects we don't want

@SethTisue
Copy link
Member Author

yup, scalacommunitybuild/scalafix@1eb5b9ca did the trick

@johnynek
Copy link

I’d love to see Paiges added to the community build.

@SethTisue
Copy link
Member Author

I’d love to see Paiges added to the community build.

@johnynek it's in.

@johnynek
Copy link

johnynek commented Sep 25, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants