Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP-NN - Converters among optional Functions, PartialFunctions and extractor objects #1135

Merged
merged 1 commit into from Aug 24, 2018

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Aug 20, 2018

@Atry
Copy link
Contributor Author

Atry commented Aug 20, 2018

I don't understand why the build fails in CI.

Anyone can help?

@Philippus
Copy link
Member

Philippus commented Aug 20, 2018

Yes, not related to your PR I think, but related to the tut upgrade we did, I've created a PR #1136

Copy link
Member

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proposal makes sense to me and I don't see any obvious problem with it. I'm happy you did this @Atry. I just left one comment to improve the proposal. It may be worth noting that this is not a compiler-related change, but a library-related change, in a more succinct way.


## Drawbacks

Why should we *not* do this. Be honest, these questions will come out during the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this section. Is this some kind of note for yourself? If not, can you clarify what you mean by this and list the drawbacks that you see from your side?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a placeholder section copied from the SIP template. I just deleted the section now.

Copy link
Member

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new cheat sheet you just added. Thanks for removing that section. LGTM.

@jvican jvican merged commit d8e8f1b into scala:master Aug 24, 2018
@Atry Atry deleted the patch-6 branch August 24, 2018 07:48
@Atry
Copy link
Contributor Author

Atry commented Aug 24, 2018

This SIP is not found in https://docs.scala-lang.org/sips/all.html. Is it the intended behavior?

@martijnhoekstra
Copy link
Contributor

Note, scala/scala#7111 indicates that this SIP may need to be skipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants