Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP draft for pattern matching with named fields #2101

Closed

Conversation

Jentsch
Copy link
Contributor

@Jentsch Jentsch commented Jun 26, 2021

No description provided.

@Jentsch
Copy link
Contributor Author

Jentsch commented Jun 26, 2021

In my local build the new SIP doesn't show up in the sip overview. (sips/all.html)

Copy link

@RubenVerg RubenVerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typos: says to instead of two at line 49, double instead of double at line 66.

@Jentsch
Copy link
Contributor Author

Jentsch commented Jun 26, 2021

Couple of typos: says to instead of two at line 49, double instead of double at line 66.

Thanks, is fixed now.

@Jentsch Jentsch changed the title draft for pattern matching with named fields SIP draft for pattern matching with named fields Jul 1, 2021
@Jentsch Jentsch force-pushed the pattern-matching-with-named-fields branch from 57e4326 to db03567 Compare February 23, 2022 22:47
@Jentsch Jentsch marked this pull request as ready for review February 24, 2022 00:34
@SethTisue
Copy link
Member

@julienrf should this be relocated to https://github.com/scala/improvement-proposals ?

@julienrf
Copy link
Contributor

Yes, thank you for pinging me Seth.
@Jentsch, may I ask you to re-submit your proposal to the scala/improvement-proposals repo? The instructions are here: https://docs.scala-lang.org/sips/sip-tutorial.html

@Jentsch
Copy link
Contributor Author

Jentsch commented Jun 16, 2022

Here is the new PR: scala/improvement-proposals#44

@Jentsch Jentsch closed this Jun 16, 2022
@julienrf
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants