SIP-52 - Binary APIs #58

nicolasstucki · 2023-02-28T10:34:25Z

No description provided.

armanbilge · 2023-03-02T01:24:39Z

content/binary-api.md

+### Removing deprecated APIs
+
+There is no precise mechanism to remove a deprecated method from a library without causing binary incompatibilities. We should have a straightforward way to indicate that a method is no longer publicly available but still available in the generated code for binary compatibility.
+
+```diff
+- @deprecated(...) def myOldAPI: T = ...
+ private[C] def myOldAPI: T = ...
+```


I believe this ties-in well with the discussion in lightbend-labs/mima#724. To summarize:

MiMa currently ignores changes to private[package] APIs, because the assumption is that these are internal to the library. This improves the signal-to-noise when making such internal changes.

As noted here, package[private] is often used for removing a public API without breaking bincompat. But, due to (1), MiMa will no longer check these now-package-private APIs for binary-compatibility, which is dangerous. The workaround is to check MiMa against every previous artifact, but this has its own costs/risks.

By adding an explicit annotation to denote public APIs, MiMa would be able to distinguish between internal APIs and once-public-now-removed APIs that must otherwise maintain binary-compatibility.

So, I hope that integration with MiMa will be considered as part of this proposal :)

Big 👍

Yes, this proposal was partially designed to address that MiMa problem.

I added the link lightbend-labs/mima#724 to the SIP document.

content/binary-api.md

smarter · 2023-03-11T19:48:30Z

content/binary-api.md

+
+```diff
+- @deprecated(...) def myOldAPI: T = ...
+ private[C] def myOldAPI: T = ...


Should this be private[pkg] ? The behavior of private[C] is to generate a name-mangled definition C$$myOldAPI to avoid clashes in case a subclass defines its own myOldAPI.

Not sure in which cases private[C] generates a mangled name. I tried the following and non of the names get mangled.

class C: private[C] def f = 1 object C: private[C] def f = 1 trait B: private[B] def f = 1 class A extends B

I do get the mangling for private[this] val in traits.

I tried the following and non of the names get mangled.

Ah, it looks like the mangling only happens in Scala 2, not Scala 3. So that's still an issue for cross-compiling codebases.

smarter · 2023-03-11T19:49:40Z

content/binary-api.md

+This annotation can be placed on `def`, `val`, `lazy val`, `var`, `object`, and `given` definitions.
+A binary API will be publicly available in the bytecode.
+
+This annotation cannot be used on `private`/`private[this]` definitions.


If this is because those get mangled, then it should also be disallowed on private[C] definitions.

Mangled names are not an issue. The problem with these is that they compile to private methods in the bytecode. The names of those methods are not mangled, and therefore a class and its parent could have two unrelated private definitions with the same name. If we make them public in the bytecode, they would clash.

smarter · 2023-03-11T19:50:04Z

content/binary-api.md

+  @binaryAPI def publicAPI: Int = ... // warn: `@binaryAPI` has no effect on public definitions
+}
+~~~
+will generate the following bytecode signatures


Since we're talking about bytecode it would be good to actually specify what we're generating at the bytecode level exactly. I assume that public in the code example below maps to ACC_PUBLIC in https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html, but we might also want to use ACC_SYNTHETIC so that these definitions stay hidden from javac and java IDEs.

Not sure if adding ACC_SYNTHETIC is always a good idea.

@binaryAPI def publicAPI: Int = ... should not be marked as ACC_SYNTHETIC because it is truly public.

Would @binaryAPI protected def publicAPI: Int = ... overridable in JAVA if it has ACC_SYNTHETIC?

Would @binaryapi protected def publicAPI: Int = ... overridable in JAVA if it has ACC_SYNTHETIC?

Yeah if you want the method to be overridable then it can't be ACC_SYNTHETIC.

smarter · 2023-03-11T19:53:09Z

content/binary-api.md

+This annotation can be placed on `def`, `val`, `lazy val`, `var`, `object`, and `given` definitions.
+The annotated definition will get a public accessor.
+
+This can be used to access `private`/`private[this]` definitions within inline definitions.


What about access to inner private classes?

Same question for primary and secondary private constructors.

What about access to inner private classes?

We currently do not allow them in inline methods. Not sure if we could use @binaryAPI to make the inner class public in the bytecode. I will investigate this possibility.

Same question for primary and secondary private constructors.

Same for the constructors. We would require @binaryAPI and not @binaryAPIAccessor in this case as well.

19165b1 adresses the question on constructors. scala/scala3#16992 Has been updated to reflect this addition.

smarter · 2023-03-11T19:56:44Z

content/binary-api.md

+}
+~~~
+
+Note that if the inlined member is `a` would be private, we would generate the accessor `C$inline$a`, which happens to be binary compatible with the automatically generated one.


I don't understand this sentence (also I think there is a typo: "is a" should be "a"?), could an example be provided?

Updated the example

smarter · 2023-03-11T19:56:53Z

content/binary-api.md

+~~~
+
+Note that if the inlined member is `a` would be private, we would generate the accessor `C$inline$a`, which happens to be binary compatible with the automatically generated one.
+This is only a tiny mitigation of binary compatibility issues compared with all the different ways accessors can be generated.


Could you elaborate on this?

Updated the example

smarter · 2023-03-11T19:57:41Z

content/binary-api.md

+* Inlining will not require the generation of an inline accessor for binary APIs.
+* Inlining will not require the generation of a new inline accessor, it will use the binary API accessors.
+* The user will be warned if a new inline accessor is automatically generated.
+  The message will suggest `@binaryAPI` or `@binaryAPIAccessor` and how to fix potential incompatibilities.


Will the message suggest using either of them? It seems we should always suggest using the latter, because it would break the ABI of existing code called from inline defs if we add the former.

Both can break the binary API.

@binaryAPI migration will always break binary compatibility.

Only if the is private/private[this] need @binaryAPIAccessor. These can break binary compatibility if the class is final.

Code like this

class A: private[foo] val foo: Int = 1 inline def inlined = foo // error

would show an error message like this

-- Error: inline-unstable-accessors.scala:3:4 ------------------------------------ 10 | valBinaryAPI + // error | ^^^^^^^^^^^^^ | Generated unstable inline accessor for value foo defined in class A. | | Annotate foo with `@binaryAPI` to make it accessible. | | Adding @binaryAPI may break binary compatibility if a previous version of this | library was compiled with Scala 3.0-3.3, Binary compatibility should be checked | using MiMa. To keep binary you can add the following accessor to class A: | @binaryAPI private[A] def foo$A$$inline$foo: Int = this.foo

More examples can be found in https://github.com/lampepfl/dotty/pull/16992/files#diff-d12e949663e52759a532bf54a827260b0513390bfcdebddf5ff1c1bd04919aaa

lrytz · 2023-03-24T15:49:11Z

content/binary-api.md

+
+Using references to `@binaryAPI` and `@binaryAPIAccessor` in inline code can cause binary incompatibilities. These incompatibilities are equivalent to the ones that can occur due to the unsoundness we want to fix. When migrating to binary APIs, the compiler will show the implementation of accessors that the users need to add to keep binary compatibility with pre-binaryAPI code.
+
+A definition can be both `@binaryAPI` and `@binaryAPIAccessor`. This would be used to indicate that the definition used to be private, but now we want to publish it as public. The definition would become public, and the accessor would be generated for binary compatibility.


the compiler will show the implementation of accessors that the users need to add to keep binary compatibility

...

the accessor would be generated for binary compatibility

IIUC, currently accessors are generated next to the inline method, whereas @binaryAPIAccessor wil generate an accessor next to the annotated private method, so that migration cannot be made in a binary compatbile manner - right?

currently accessors are generated next to the inline method

This is the case if the inline method is in a different class from the accessed member.

On the other hand, if the inline method is in the class the accessor will be placed in the class that defines the accessed members, similar to @binaryAPIAccessor. In some cases, these accessors are the same and we avoid binary incompatibilities in the migration from auto-generated to @binaryAPIAccessor (example 1).

@binaryAPIAccessor wil generate an accessor next to the annotated private method, so that migration cannot be made in a binary compatbile manner?

In general, the migration can't be made binary-compatible. We chose to reuse the accessor name <fullClassName>$$inline$<definitionName> to be binary compatible with some auto-generated accessors. The accessors that are binary compatible are the ones in a non-final class that are generated by an inline method in that class (example 1).

Example 1 (compatible):

class A(x: Int): inline def y = x + 1 // inline def y = A$$inline$x + 1 // def A$$inline$x = x // auto-generated

migrates to

class A(@binaryAPIAccessor x: Int): inline def y = x + 1 // inline def y = A$$inline$x + 1 // def A$$inline$x = x // generated by @binaryAPIAccessor

Example 2 (incompatible):

final class A(x: Int): inline def y = x + 1 // inline def y = inline$x + 1 // def inline$x = x // auto-generated

migrates to

class A(@binaryAPIAccessor x: Int): inline def y = x + 1 // inline def y = A$$inline$x + 1 def inline$x = x // user needs to add this. Migration warning shows tells the users shows this code // def A$$inline$x = x // generated by @binaryAPIAccessor

Example 3 (incompatible):

package p final class A(private[p] x: Int)

package p inline def f(a: A): Int = a.x // inline def f(a: A): Int = A$$inline$x(a) // def A$$inline$x(a: A) = a.x // auto-generated

migrates to

package p final class A(@binaryAPI private[p] x: Int)

package p inline def f(a: A): Int = a.x // inline def f(a: A): Int = a.x def A$$inline$x(a: A) = a.x // user needs to add this. Migration warning shows tells the users shows this code

In general, the migration can't be made binary-compatible

In that case, it's maybe not worth introducing both @binaryAPI and @binaryAPIAccessor? Is it always possible to start using @binaryAPI and maintain binary compatibility by manually adding the accessors that were previously generated by the compiler?

The issue with that approach is that users would need to change all their private/private[this] members that are accessed from inline methods to protected/private[Cls]/pribate[pack]. This can cause source incompatibilities and unintentionally leak private members beyond the scope of inlining.

I don't understand, I'm sorry. Where am I wrong?

Currently, if a private method is accessed in an inline def, the compiler generates an accessor to the private method

The user can annotate the method @binaryAPI (but keep it private in source), which makes it public in bytecode, and the accessor is no longer generated

To maintain binary compatibility, the user can write the accessor that was previously generated into the source code

The user can annotate the method @binaryapi (but keep it private in source), which makes it public in bytecode, and the accessor is no longer generated

@binaryAPI cannot be placed on private/private[this] APIs. This is because that change could be a source or binary incompatible change. For example:

class A: @binaryAPI private val x: Int = 1 // should not be allowed def f: Int = x class B extends A: val x: Int = 2

If we make x public in the bytecode, we would accidentally make B.x override A.x which would change the semantics of a private definition. Or we would have to flag them as overrides of private members, which implies that we would have to rename anything that would clash with a @binaryAPI private. In this case we would not be able to use the name x in B anymore.

Ah, right, thanks. Was name-mangling considered?

"Only add @binaryAPIAccessor" could also be an option. The concern

The drawback is that we would add code size and runtime overhead to all uses of this feature

is maybe minor? Accessors are very common in Scala, why would these ones be problematic?

"Only add @binaryAPIAccessor" could also be an option.

If we do that we would not cover 2 of the motivations: Removing deprecated APIs and No way to inline reference to private constructors. Those use cases could be supported later with the addition of @binaryAPI.

If we add @binaryAPI later there is also a migration concern. In a first step users would add @binaryAPIAccessor to all the definitions, but then when @binaryAPI they might also want to add that one to access the member directly. This would force them to have both @binaryAPIAccessor and @binaryAPI. If we add both at the same time, then they would be able to only use @binaryAPI.

Ah, right, thanks. Was name-mangling considered?

I assume with @binaryAPIAccessor of private members. The issue is that we would need to mangle the names of private members but not public/protected members. This implies that if the user changes a private member into a public one the accessor would not be generated anymore. This is the exact same issue we have right now but triggered in a different way.

Thanks for the details. I don't want to be annoying and keep discussing details here, the discussion should move elsewhere?

I think introducing two annotations is bad. Users will have to pick one or the other, they have to know how they both work and how using them affects binary compatibility.

I do not see a scenario where a user would need to think about which annotation to choose. In the scenario of Removing deprecated APIs they can only use @binaryAPI. In all other scenarios with inlining, the users would be told which annotation they need to use.

julienrf

I reviewed the format and style. Please keep in mind that the proposals are ultimately published to https://docs.scala-lang.org/sips so the markup has to be valid, and the content should be as clear as possible.

content/binary-api.md

julienrf · 2023-05-11T05:42:40Z

content/binary-api.md

+~~~
+
+In the bytecode, `@binaryAPI` definitions will have the [ACC_PUBLIC](https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.1-200-E.1) flag.
+<!-- We can also set the [ACC_SYNTHETIC](https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.1-200-E.1) to hide these definitions from javac and java IDEs. -->


Has this been studied further? Is there a conclusion?

I found that we currently need to do that for other accessors. I opened a discussion in scala/scala3#17461. @binaryAPI should have ACC_SYNTHETIC if and only if other accessors.

content/binary-api.md

JD557 · 2023-05-11T07:57:08Z

content/binary-api.md

+
+### Removing deprecated APIs
+
+There is no precise mechanism to remove a deprecated method from a library without causing binary incompatibilities. We should have a straightforward way to indicate that a method is no longer publicly available but still available in the generated code for binary compatibility.


Is this an actual problem?

Based on the Semantic Versioning spec and a discussion with clarifications, my understanding is that the semver way would require a MAJOR version bump to remove a deprecated method.

Binary incompatibility of different major versions seems like a reasonable expectation.

There are obviously other version schemes other than semver, but I imagine the handling of deprecated APIs is similar (e.g. I think PVP is even more extreme, where both deprecating and removing the API would require a major bump)

Yes, this is an actual problem because the Scala ecosystem, and therefore use of SemVer, is rooted in binary and TASTy compatibility. You want to be able to make source breaking changes while retaining binary and TASTy compatibility, and that should stay a MINOR version bump. Perhaps you are mitigating the source breakage with extension methods or new overloads instead.

(If breaking source compat required a MAJOR version bump in Scala, every new version of a library with a new public class or method would be a MAJOR version, and we don't want that for obvious reasons.)

Co-authored-by: Julien Richard-Foy <julien@richard-foy.fr>

lrytz · 2023-10-23T13:44:36Z

This SIP was unanimously accepted in the meeting on Friday, congratulations @nicolasstucki!

As this SIP was never discussed on Discourse, could you open a thread saying that this SIP will be implemented as an experimental feature?

In terms of tooling affected by this SIP, MiMa (cc @dwijnand) and TASTy-MiMa (cc @sjrd) was mentioned in the meeting.

lrytz · 2023-10-23T13:47:10Z

(Also, there was no reply to my previous comment from September.)

A binary API is a definition that is annotated with `@publicInBinary` or overrides a definition annotated with `@publicInBinary`. This annotation can be placed on `def`, `val`, `lazy val`, `var`, `object`, and `given` definitions. A binary API will be publicly available in the bytecode. It cannot be used on `private`/`private[this]` definitions. This is useful in combination with inline definitions. If an inline definition refers to a private/protected definition marked as `@publicInBinary` it does not need to use an accessor. We still generate the accessors for binary compatibility but do not use them. If the linting option `-WunstableInlineAccessors` is enabled, then a warning will be emitted if an inline accessor is generated. The warning will guide the user to the use of `@publicInBinary`. For SIP: scala/improvement-proposals#58

Introduces [SIP-52](scala/improvement-proposals#58) as experimental feature. A binary API is a definition that is annotated with `@publicInBinary` or overrides a definition annotated with `@publicInBinary`. This annotation can be placed on `def`, `val`, `lazy val`, `var`, `object`, and `given` definitions. A binary API will be publicly available in the bytecode. It cannot be used on `private`/`private[this]` definitions. This is useful in combination with inline definitions. If an inline definition refers to a private/protected definition marked as `@publicInBinary` it does not need to use an accessor. We still generate the accessors for binary compatibility but do not use them. If the linting option `-WunstableInlineAccessors` is enabled, then a warning will be emitted if an inline accessor is generated. The warning will guide the user to the use of `@publicInBinary`.

nicolasstucki · 2023-10-26T08:29:50Z

As this SIP was never discussed on Discourse, could you open a thread saying that this SIP will be implemented as an experimental feature?

Added in https://contributors.scala-lang.org/t/updates-on-sip-52-publicinbinary-and-wunstableinlineaccessors/6363

nicolasstucki · 2023-10-26T08:44:48Z

I have a question about -WunstableInlineAccessors. I think there are two cases:

A library with an existing inline def that accesses a private member. Here the author should create a binary copmatible accessor with the same name as was previously compiler-generated. The warning tells the user that accessor name. It was actually suggested that the compiler could insert the accessor to the source file using -rewrite.

We have all the necessary information to be able to create the accessor using -rewrite. I will have a look at how to implement this later.

When someone writes a new inline def that accesses a private member, the user should get a warning. Here the warning should not suggest to create an accessor with a mangled name with $ signs. Is this case also addressed?

I am not sure if that is possible. I have not found a way to know if an inline def is new or not while compiling that source file. It seems we only know this kind of information in MiMa or TASTy MiMa.

Introduces [SIP-52](scala/improvement-proposals#58) as experimental feature. A binary API is a definition that is annotated with `@publicInBinary` or overrides a definition annotated with `@publicInBinary`. This annotation can be placed on `def`, `val`, `lazy val`, `var`, `object`, and `given` definitions. A binary API will be publicly available in the bytecode. It cannot be used on `private`/`private[this]` definitions. This is useful in combination with inline definitions. If an inline definition refers to a private/protected definition marked as `@publicInBinary` it does not need to use an accessor. We still generate the accessors for binary compatibility but do not use them. If the linting option `-WunstableInlineAccessors` is enabled, then a warning will be emitted if an inline accessor is generated. The warning will guide the user to the use of `@publicInBinary`.

lrytz · 2023-10-26T09:15:47Z

I am not sure if that is possible. I have not found a way to know if an inline def is new or not while compiling that source file. It seems we only know this kind of information in MiMa or TASTy MiMa.

It should be fine if the compiler message is clear about the various options, which you implemented already behind -explain IIUC.

nicolasstucki · 2023-10-26T09:57:06Z

It should be fine if the compiler message is clear about the various options, which you implemented already behind -explain IIUC.

This is the -explain message @lrytz mentioned: https://github.com/lampepfl/dotty/pull/18402/files#diff-e054695755ff26925ae51361df0f7cd4940bc1fd7ceb658023d0dc38c18178c3R3106-R3111

Introduces [SIP-52](scala/improvement-proposals#58) as experimental feature. A binary API is a definition that is annotated with `@publicInBinary` or overrides a definition annotated with `@publicInBinary`. This annotation can be placed on `def`, `val`, `lazy val`, `var`, `object`, and `given` definitions. A binary API will be publicly available in the bytecode. It cannot be used on `private`/`private[this]` definitions. This is useful in combination with inline definitions. If an inline definition refers to a private/protected definition marked as `@publicInBinary` it does not need to use an accessor. We still generate the accessors for binary compatibility but do not use them. If the linting option `-WunstableInlineAccessors` is enabled, then a warning will be emitted if an inline accessor is generated. The warning will guide the user to the use of `@publicInBinary`.

…ing flag (#18402) Introduces [SIP-52](scala/improvement-proposals#58) as an experimental feature. Fixes #16983 ### `@publicInBinary` A binary API is a definition that is annotated with `@publicInBinary` or overrides a definition annotated with `@publicInBinary`. This annotation can be placed on `def`, `val`, `lazy val`, `var`, `object`, and `given` definitions. A binary API will be publicly available in the bytecode. It cannot be used on `private`/`private[this]` definitions. #### Interaction with inline This is useful in combination with inline definitions. If an inline definition refers to a private/protected definition marked as `@publicInBinary` it does not need to use an accessor. We still generate the accessors for binary compatibility but do not use them. ### `-WunstableInlineAccessors` If the linting option `-WunstableInlineAccessors` is enabled, then a warning will be emitted if an inline accessor is generated. The warning will guide the user to the use of `@publicInBinary`.

If non-static inline accessor is generated we do not we can tell the user why they cannot access the macro implementation this way. Currently we do not have a clean way to fix this code, but in the future [SIP-58](scala/improvement-proposals#58) would introduce a way to not generate this accessor. Fixes #15413 [Cherry-picked f1db208]

nicolasstucki mentioned this pull request Feb 28, 2023

Add @binaryAPI and @binaryAPIAccessor scala/scala3#16992

Closed

julienrf changed the title ~~Add Binary APIs SIP~~ SIP-52 - Binary APIs Feb 28, 2023

julienrf added stage:design status:under-review labels Feb 28, 2023

julienrf assigned dragos and raulraja Feb 28, 2023

julienrf requested review from dragos and raulraja February 28, 2023 13:02

julienrf assigned smarter Feb 28, 2023

julienrf requested a review from smarter February 28, 2023 13:27

nicolasstucki force-pushed the binary-api branch from bb9fa0f to 53ebdda Compare February 28, 2023 16:09

Add Binary APIs SIP

3b7acde

nicolasstucki force-pushed the binary-api branch from 53ebdda to 3b7acde Compare February 28, 2023 16:10

armanbilge reviewed Mar 2, 2023

View reviewed changes

nicolasstucki added 2 commits March 2, 2023 08:36

Add MiMa classic to the list of other concerns.

9806825

Add reference to discussion on private[pkg]

de9c9df

smarter reviewed Mar 11, 2023

View reviewed changes

nicolasstucki added 3 commits March 14, 2023 14:37

Add mention to ACC_PUBLIC and ACC_SYNTHETIC

0861c51

Allow to use binaryAPI on private constructors.

19165b1

Update binary API and inlining example

2857ccd

lrytz reviewed Mar 24, 2023

View reviewed changes

julienrf requested a review from smarter May 5, 2023 13:28

This comment was marked as outdated.

Sign in to view

julienrf reviewed May 11, 2023

View reviewed changes

JD557 reviewed May 11, 2023

View reviewed changes

Apply suggestions from code review

eb57925

Co-authored-by: Julien Richard-Foy <julien@richard-foy.fr>

nicolasstucki force-pushed the binary-api branch from 7838391 to eb57925 Compare May 11, 2023 09:42

Add private constructors example

1d22f52

julienrf assigned lrytz and unassigned dragos May 15, 2023

anatoliykmetyuk added stage:implementation status:waiting-for-implementation and removed status:under-review labels Oct 20, 2023

lrytz merged commit b938e73 into scala:main Oct 23, 2023

nicolasstucki deleted the binary-api branch October 26, 2023 08:44

odersky added status:waiting-for-implementation and removed status:waiting-for-implementation stage:implementation labels Apr 30, 2024


		Using references to `@binaryAPI` and `@binaryAPIAccessor` in inline code can cause binary incompatibilities. These incompatibilities are equivalent to the ones that can occur due to the unsoundness we want to fix. When migrating to binary APIs, the compiler will show the implementation of accessors that the users need to add to keep binary compatibility with pre-binaryAPI code.

		A definition can be both `@binaryAPI` and `@binaryAPIAccessor`. This would be used to indicate that the definition used to be private, but now we want to publish it as public. The definition would become public, and the accessor would be generated for binary compatibility.


		### Removing deprecated APIs

		There is no precise mechanism to remove a deprecated method from a library without causing binary incompatibilities. We should have a straightforward way to indicate that a method is no longer publicly available but still available in the generated code for binary compatibility.

SIP-52 - Binary APIs #58

SIP-52 - Binary APIs #58

Conversation

nicolasstucki commented Feb 28, 2023 • edited by anatoliykmetyuk Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smarter Mar 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smarter Mar 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lrytz Mar 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Example 1 (compatible):

Example 2 (incompatible):

Example 3 (incompatible):

Choose a reason for hiding this comment

nicolasstucki Apr 12, 2023 • edited Loading

Choose a reason for hiding this comment

lrytz Apr 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as outdated.

julienrf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JD557 May 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lrytz commented Oct 23, 2023

lrytz commented Oct 23, 2023

nicolasstucki commented Oct 26, 2023

nicolasstucki commented Oct 26, 2023

lrytz commented Oct 26, 2023

nicolasstucki commented Oct 26, 2023

nicolasstucki commented Feb 28, 2023 •

edited by anatoliykmetyuk

Loading

smarter Mar 11, 2023 •

edited

Loading

smarter Mar 11, 2023 •

edited

Loading

lrytz Mar 24, 2023 •

edited

Loading

nicolasstucki Apr 12, 2023 •

edited

Loading

lrytz Apr 12, 2023 •

edited

Loading

JD557 May 11, 2023 •

edited

Loading