scalafix: leverage scalafixEnable & scalafixAll #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
docs
branch
3 times, most recently
from
1198757
to
3f754f6
Compare
bjaglin
commented
Jul 15, 2022
README.md
Outdated
|
|
||
| ```scala | ||
| // project/plugins.sbt | ||
| addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.9.34") | ||
| addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.10.1") |
There was a problem hiding this comment.
let's hold the merge of that doc, as invalid code may be generated when scalafix 0.10.x runs a version of the migration prior to #549
bjaglin
commented
Jul 15, 2022
| libraryDependencies += "org.scala-lang.modules" %% "scala-collection-compat" % "<version>" | ||
| addCompilerPlugin(scalafixSemanticdb) | ||
| scalacOptions ++= List("-Yrangepos", "-P:semanticdb:synthetics:on") |
There was a problem hiding this comment.
oops, synthetics are used in the rule, so we'll need to keep that :(
|
you're saying we should roll a release, then merge this? do I understand correctly? |
Closed
|
okay; release ticket #552 |
|
thanks @bjaglin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scalafixEnablecommand is used by scala-steward for more than 3 years and got some further improvements lately, so I think it's safe to rely on it instead of asking users to update their build.