Rewrite Map.mapValues -> Map.mapValues.toMap #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch looks good but it should not be part of the |
|
I think it’s simpler to first address #56 but I’m fine as long as both approaches are eventually consistent. |
MasseGuillaume
force-pushed
the
map-mapValues
branch
2 times, most recently
from
78fd1fb
to
84bac1b
Compare
|
I will merge this one, can you fix the conflict? |
MasseGuillaume
force-pushed
the
map-mapValues
branch
from
84bac1b
to
dcc68d7
Compare
|
✔️ |
2 tasks
martijnhoekstra
pushed a commit
to martijnhoekstra/scala-collection-compat
that referenced
this pull request
Nov 9, 2022
* Documentation and tests for Iterator.intersperse. * Added some missing scala-doc and unit tests for `IteratorDecorator`. Corrected order of arguments to assertEquals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.