Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Scalafmt (from 1.5.1 to 3.7.4) and reformat sources #604

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

SethTisue
Copy link
Member

I spent a certain amount of time tinkering with .scalafmt.conf trying to make the diff smaller

@julienrf do you see any opportunities to minimize the diff further...?

@SethTisue
Copy link
Member Author

SethTisue commented Jun 16, 2023

I've pushed another commit that switches align.preset from more to none

more does a lot more than it did in Scalafmt 1.x, and it seems overbearing to me and likely to result in ongoing annoying diffs in the future if we keep it on. so while we're reformatting anyway, let's disable it and pay the one-time diffs cost

@SethTisue
Copy link
Member Author

there's a few places where it's inserting an annoying newline after implicit, and I fooled with newlines.implicitParamListModifierXXX and wasn't able to improve it, so I think we can let that go

there were certainly some cases where the alignment was nice-looking, but a lot of others that I found annoying... and most tooling is not likely to preserve the alignment anyway, during development

many of the remaining diffs insert a space to change //foo to // foo, which I can live with

marking as ready for review

@SethTisue SethTisue marked this pull request as ready for review June 16, 2023 00:44
@SethTisue SethTisue merged commit cb11b0d into scala:main Jun 30, 2023
24 checks passed
@SethTisue SethTisue deleted the scalafmt-upgrade branch June 30, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant