-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New circular Seq operations: rotateRight, rotateLeft, startAt #168
Open
mcallisto
wants to merge
9
commits into
scala:main
Choose a base branch
from
mcallisto:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
743ba43
New circular Seq operations: rotateRight, rotateLeft, startAt
mcallisto 1006d1e
Improved methods descriptions
mcallisto ba5d900
Failing test on rotating empty Seq
mcallisto d123653
Clearer failing test
mcallisto 7ad2695
Failing test now ok
mcallisto ebab807
Improved tests
mcallisto 3362ce5
Correct examples in descriptions
mcallisto 3d198ba
Improved test on String
mcallisto 3577f3c
Deleted method rotateAt and added applyO
mcallisto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this method should exists. When I have read its description, I though: but this is the same as
rotateLeft
. Once I have checked the implementation, I see it really just calls it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OndrejSpanel I can definitely see your point.
The reason why, at the end, I went for the proposed duplication is that
startAt
accepts an index, whilerotateLeft
accepts a number of steps. Even if the result is the same, depending on how you see the circular sequence both can feel more natural.Just as an example,
startAt
plays nicely withreflectAt
another method you can find in my more complete and documentedRingSeq
library, see https://scala-tessella.github.io/ring-seq/usage.html