Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explicit type #106

Merged
merged 1 commit into from Sep 12, 2023
Merged

add explicit type #106

merged 1 commit into from Sep 12, 2023

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Sep 11, 2023

prepare Scala 2.13.12

[error] laws/src/main/scala/Test.scala:97:17: under -Xsource:3, inferred Class[_] instead of Class[_ <: A] [quickfixable]
[error] Scala 3 migration messages are errors under -Xsource:3. Use -Wconf / @nowarn to filter them or add -Xmigration to demote them to warnings.
[error] Applicable -Wconf / @nowarn filters for this fatal warning: msg=<part of the message>, cat=scala3-migration, site=laws.Test.boxedRuntime
[error]   protected def boxedRuntime = a.getClass
[error]                 ^
[error] laws/src/main/scala/Test.scala:99:7: under -Xsource:3, inferred Class[_] instead of Class[_ <: CC] [quickfixable]
[error] Scala 3 migration messages are errors under -Xsource:3. Use -Wconf / @nowarn to filter them or add -Xmigration to demote them to warnings.
[error] Applicable -Wconf / @nowarn filters for this fatal warning: msg=<part of the message>, cat=scala3-migration, site=laws.Test.runtimeColl
[error]   def runtimeColl = x.getClass
[error]       ^
[error] two errors found
[error] (laws / Compile / compileIncremental) Compilation failed

@SethTisue
Copy link
Member

review by @scala/collections ?

@Ichoran
Copy link
Contributor

Ichoran commented Sep 12, 2023

LGTM

1 similar comment
@jxnu-liguobin
Copy link
Member

LGTM

Copy link

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@SethTisue SethTisue merged commit ab65292 into scala:main Sep 12, 2023
3 checks passed
@xuwei-k xuwei-k deleted the explicit-type branch September 12, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants