change our CI (org-wide) to use AdoptOpenJDK

[SethTisue]

@adriaanm I wrote down "create an Adopt OpenJDK ticket, assign it to myself, say I plan to do it in January" but now I can't remember what this meant exactly... was it to add AdoptOpenJDK to our scala/scala CI matrix, or the community build, or what? if you can't remember either I can review the team meeting video and find out

[adriaanm]

it was originally about standardizing on adoptopenjdk hotspot on travis ci (installed using jabba), but in the mean time we're no longer sure because they have not yet been able to license the TCK

[SethTisue]

okay, we'll do nothing for now, and re-sync with others at Lightbend on this in January or whenever. it's mainly downstream projects (Akka, Play, etc) where it might really matter actually, so we can wait and follow their lead.

[SethTisue]

note to self, since I already forgot once: the issue is that Oracle OpenJDK, which we're currently using on our own machines and on Jenkins and Travis, will eventually stop receiving security updates. that's the reason we will ultimately want to be using AdoptOpenJDK (or something)

[dwijnand]

Setting up Travis CI to use AdoptOpenJDK is quite simple:

before_install: curl -Ls https://git.io/jabba | bash && . ~/.jabba/jabba.sh
install: jabba install adopt@1.8.202-08 && jabba use "$_" && java -version

An example of a matrix using v8 and v11, with v11 being allowed to fail:

before_install: curl -Ls https://git.io/jabba | bash && . ~/.jabba/jabba.sh
install: jabba install "$TRAVIS_JDK" && jabba use "$_" && java -version

env:
  - TRAVIS_JDK=adopt@1.8.202-08
  - TRAVIS_JDK=adopt@1.11.0-2

matrix:
  fast_finish: true
  allow_failures:
    - env: TRAVIS_JDK=adopt@1.11.0-2 # not fully supported but allows problem discovery

And don't forget to cache the installed jdks:

cache:
  directories:
    - $HOME/.jabba/jdk

[SethTisue]

@eed3si9n is working on this

[eed3si9n]

• scala/scala JDK 8 - Use AdoptOpenJDK JDK 8 for testing [ci: last-only] scala#7931
• scala/scala JDK 11 - Add AdoptOpenJDK JDK 11 to the PR validation scala#8207
• scala/scala-xml - Use AdoptOpenJDK JDK 8 and 11 scala-xml#334
• scala/scala-parser-combinators - Use AdoptOpenJDK JDK 8 and 11 scala-parser-combinators#228
• scala/scala-collection-compat - Use AdoptOpenJDK JDK 8 and 11 scala-collection-compat#231
• scala/scala-java8-compat - Use AdoptOpenJDK JDK 8 and 11 scala-java8-compat#156
• scala/scala-parallel-collections - Use AdoptOpenJDK JDK 8 and 11 scala-parallel-collections#74
• slick/slick - Use AdoptOpenJDK JDK 8 and 11 slick/slick#2050

[SethTisue]

I think this is done, or done enough to close the ticket anyway, any missing repo would be a very obscure one, I think. all the modules repos are using https://github.com/scala/scala-dev/blob/scala-dev/travis/default.yml. the community build is on AdoptOpenJDK (for 11+ anyway, not sure about 8, but whatevs)