Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JLine 3: turn Som's old checklist into tickets #689

Closed
9 tasks
SethTisue opened this issue Mar 5, 2020 · 5 comments
Closed
9 tasks

JLine 3: turn Som's old checklist into tickets #689

SethTisue opened this issue Mar 5, 2020 · 5 comments
Labels
t:repl JLine 3 upgrade (scala/scala#8036)

Comments

@SethTisue
Copy link
Member

SethTisue commented Mar 5, 2020

on ye olde JLine 3 PR, @som-snytt had this checklist:

We need to march down this list and figure out what was already fixed, and for the rest, make tickets here

@SethTisue SethTisue added the t:repl JLine 3 upgrade (scala/scala#8036) label Mar 5, 2020
@SethTisue
Copy link
Member Author

SethTisue commented Mar 6, 2020

None of these look like 2.13.2 blockers to me, but I'd like to know what @som-snytt thinks — Som, can you provide descriptions for these?

@SethTisue
Copy link
Member Author

SethTisue commented Mar 6, 2020

"Coursier convenience", does that refer to pulling in dependencies at runtime? that'd be awesome, but not a blocker of course

UPDATE: I'll assume that, and it's covered under #325

@SethTisue
Copy link
Member Author

SethTisue commented Mar 6, 2020

"Excise old continuation handling", finally figured out that "continuation" refers to multiline support. So I guess there's old code related to how we used to do that, that we can delete now that JLine supports it directly

UPDATE: but I found later that ReplTest still does it the old way

@SethTisue
Copy link
Member Author

Excise old continuation handling

the old code is causing actual trouble at #703

@SethTisue
Copy link
Member Author

the old code is causing actual trouble at #703

false alarm.

I'm going to close this, since nothing further that's obviously actionable has surfaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:repl JLine 3 upgrade (scala/scala#8036)
Projects
None yet
Development

No branches or pull requests

1 participant