Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala.js snippet on frontpage is broken #1667

Closed
OlegYch opened this issue Jun 28, 2024 · 6 comments
Closed

scala.js snippet on frontpage is broken #1667

OlegYch opened this issue Jun 28, 2024 · 6 comments

Comments

@OlegYch
Copy link

OlegYch commented Jun 28, 2024

running https://scastie.scala-lang.org/gyNudjdITL2irc9ni0kRxA fails with

org.scalajs.ir.IRVersionNotSupportedException: Failed to deserialize a file compiled with Scala.js 1.16 (supported up to: 1.13): /home/sbtRunnerContainer/.cache/coursier/v1/https/repo1.maven.org/maven2/org/scala-js/scalajs-library_2.13/1.16.0/scalajs-library_2.13-1.16.0.jar:/scala/scalajs/LinkingInfo.sjsir
You may need to upgrade the Scala.js sbt plugin to version 1.16 or later.
@sjrd
Copy link
Member

sjrd commented Jun 28, 2024

@rochala Looks like Scastie needs to bump its Scala.js version to 1.16.0. Are you still in charge of Scastie?

@rochala
Copy link
Contributor

rochala commented Jun 28, 2024

Are you still in charge of Scastie?

I'm still trying to maintain it. I'll redeploy it today

@OlegYch
Copy link
Author

OlegYch commented Jun 28, 2024

@sjrd i think it's a matter of creating a new snippet and updating the link

@rochala
Copy link
Contributor

rochala commented Jun 28, 2024

It seems that Scala.js is already at 1.16, @OlegYch is right. It seems like changing a versions doesn't update Scala.js plugin version in configuration so there is a bug indeed. To update sbt plugin version you need to switch target to e.g jvm and then back to JS

This is the new link working on latest LTS with latest library versions.
https://scastie.scala-lang.org/CQ70LFpbRJuWEDfGxbuYeQ

@sjrd
Copy link
Member

sjrd commented Jun 28, 2024

Thanks for the link! PR to include it at #1668.

@sjrd sjrd closed this as completed in 1943295 Jun 28, 2024
sjrd added a commit that referenced this issue Jun 28, 2024
Fix #1667: Update the link for the Scala.js snippet.
@rochala
Copy link
Contributor

rochala commented Jun 28, 2024

The long term solution for this, would be adding a support for github organisations to login to Scastie, and then migrate all snippets there. We could then modify snippets, without the need for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants