Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link api docs from release page #1352

Merged
merged 1 commit into from
Mar 14, 2022
Merged

link api docs from release page #1352

merged 1 commit into from
Mar 14, 2022

Conversation

bishabosha
Copy link
Member

@bishabosha bishabosha commented Mar 14, 2022 •
edited
Loading

I've added API docs link to the "ribbon" of a release if there is a known API docs for it.

Screenshot 2022-03-14 at 15 01 09

open questions:

  • will old API docs get deleted eventually, making dead links (I guess a CI check may fail here)
  • is the ribbon appropriate, alternatively we could have a section in the main body to link also the compiler and reflect APIs

julienrf
julienrf approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@SethTisue SethTisue merged commit 64ae62d into scala:main Mar 14, 2022
@SethTisue SethTisue mentioned this pull request Mar 14, 2022
Closed
@SethTisue
Copy link
Member

SethTisue commented Mar 14, 2022 •
edited
Loading

nice! I'll take care of making the corresponding change over in the make-release-notes repo: scala/make-release-notes#437

@bishabosha bishabosha mentioned this pull request Mar 14, 2022
Closed
@julienrf julienrf deleted the link-api-on-release branch April 11, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf approved these changes

@SethTisue SethTisue Awaiting requested review from SethTisue

Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bishabosha @SethTisue @julienrf