Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release version 1.0.0 #80

Closed
SethTisue opened this issue Oct 13, 2019 · 14 comments
Closed

release version 1.0.0 #80

SethTisue opened this issue Oct 13, 2019 · 14 comments
Assignees

Comments

@SethTisue
Copy link
Member

SethTisue commented Oct 13, 2019

we might as well, right?

but note that #5 / scala/community-build#981 needs to be dealt with before doing a next release of any kind — since the sbt-scala-module/sbt-osgi upgrade that @lrytz did, our OSGi settings are making us publish an incomplete JAR

@SethTisue
Copy link
Member Author

SethTisue commented Feb 13, 2020

we also had OSGi trouble in scala-collection-contrib (scala/scala-collection-contrib#51) and ended up throwing up our hands (see https://github.com/scala/scala-collection-contrib/pull/72/files for the diffs) and documenting the lack of OSGI support with a "help wanted" ticket (scala/scala-collection-contrib#71)

and in scala-java8-compat similarly: scala/scala-java8-compat#107

I think we should do that here as well

@SethTisue
Copy link
Member Author

SethTisue commented Apr 22, 2020

@lrytz said yes, let's go 1.0

#99 has been merged, removing OSGi support

@SethTisue
Copy link
Member Author

over at #101 the possibility was raised of removing IterableOnce as a parent type of the parallel collections. delaying a bit longer to see if there's any further debate on that, and/or a PR. (though I feel like it's a pretty basic design choice to be revisiting this late, so my hunch is that the status quo will prevail....)

@SethTisue
Copy link
Member Author

I am resuming work on this and hope to publish within the next 2 weeks or so. (scala-collection-compat is ahead of it in my queue.)

@SethTisue SethTisue self-assigned this Sep 3, 2020
@SethTisue
Copy link
Member Author

SethTisue commented Sep 14, 2020

sigh, 6ebdf09 is massively binary incompatible, says MiMa

I suspect it's right. in the morning I'll think about whether it's somehow wrong (perhaps the changes aren't visible to user code), but I'm not optimistic.

supposing it's right, then:

if we leave the changes in place, we break bincompat. but if we revert them, I doubt the code can be compiled on Dotty, though I can check and see.

breaking bincompat is fair game for 1.0, but we shouldn't do it lightly, since 0.2.0 has been out for quite a while now and libraries may have dependencies on it.

and this has me thinking that before we go 1.0, we ought to add Dotty to the crossbuild. so I'm adding that to the steps above.

@NthPortal
Copy link
Contributor

just to clarify, this will be 1.0.0 rather than 1.0, correct?

@SethTisue
Copy link
Member Author

this will be 1.0.0 rather than 1.0, correct?

yes

@NthPortal NthPortal changed the title release version 1.0 release version 1.0.0 Sep 15, 2020
@SethTisue
Copy link
Member Author

merged Dotty PRs: #117, #118, #119, #120

then #113 finishes it off — it's ready for review

@SethTisue
Copy link
Member Author

About breaking bincompat, 1) I simply don't see a way around it, but 2) I think I've managed to convince myself it isn't so bad because afaict ordinary users won't be affected, the only people who might be affected (afaict) are those who are writing their own splitters, that kind of thing — it isn't even obvious to me, for lack of detailed knowledge of the APIs, whether it's likely that even those folks would be affected in practice.

So I think I've made peace with it.

@SethTisue
Copy link
Member Author

SethTisue commented Oct 26, 2020

PRs all merged. Next step is simply to wait until Scala 3.0.0-M1 is out. Once that happens, I suppose we ought to do 1.0.0-RC1 first before going full 1.0.0. (Steps above, updated.)

@SethTisue SethTisue removed their assignment Oct 27, 2020
@SethTisue
Copy link
Member Author

SethTisue commented Nov 5, 2020

1.0.0-RC1 release checklist

@SethTisue
Copy link
Member Author

1.0.0-RC1 is published

https://twitter.com/SethTisue/status/1324159849387581441

@SethTisue SethTisue self-assigned this Nov 5, 2020
@SethTisue
Copy link
Member Author

SethTisue commented Nov 18, 2020

@SethTisue
Copy link
Member Author

IT IS DONE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants