Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSGi -split-package:=first seems unsafe #97

Closed
lrytz opened this issue Apr 16, 2020 · 2 comments · Fixed by #99
Closed

OSGi -split-package:=first seems unsafe #97

lrytz opened this issue Apr 16, 2020 · 2 comments · Fixed by #99

Comments

@lrytz
Copy link
Member

lrytz commented Apr 16, 2020

I took the current master branch of this repo and ran in sbt 1. show core/package and 2. core/publishLocal on my machine. When comparing the content of the jars, the publish one includes includes the wrong classfiles in the scala/collection/ package, it's the classes of the standard library instead of those in the module.

Diff is here: https://gist.github.com/lrytz/96e397595a4be5fbfe7a9b80baf48f28/revisions

It seems the assumption mentioned here is not correct:

// The first entry on the classpath is the project's target classes dir but sbt-osgi also passes all
// dependencies to bnd. Any "merge" strategy for split packages would include the classes from scala-library.

I think this is pretty risky, and we should probably disable OSGi support if noone knows a better solution. cc @SethTisue.

@SethTisue
Copy link
Member

agree, let's do that. also wdyt about #80 which proposes going to version 1.0?

@lrytz
Copy link
Member Author

lrytz commented Apr 17, 2020

Bumping to 1.0.0 sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants