Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed JSON deprecation warnings #32

Merged
merged 1 commit into from Sep 29, 2014
Merged

Removed JSON deprecation warnings #32

merged 1 commit into from Sep 29, 2014

Conversation

propensive
Copy link
Contributor

Removes the deprecation warnings which were added to JSON objects and classes prior to their removal from the Scala standard library. Now that this project has been branched into a separate module, the deprecation warnings can be removed.

@gourlaysama
Copy link
Member

LGTM, thanks! Now I am wondering why only the JSON package got deprecated...

@soc: was there any other reason for this being deprecated, apart from the move (you deprecated it in scala/scala@3e1a075)?

@soc
Copy link
Member

soc commented Sep 26, 2014

Yes, the disastrous performance. You shouldn't be using scala-parser-combinators in the first place, but the toy implementation of JSON was just even more misleading than the existence of parser combinators in the standard library, because users thought it was intended for usage in production.

Basically, the whole split-into-a-module was a way to get rid of it as fast as possible.

Just like for akka-actors, it would be good to write a migration document to move scala-parser-combinator code to parboiled2 and let scala-parser-combinators die.

So the right action is to add @deprecated to the rest of the library, announce that it will go away, and get rid of it for good.

There is no point in keeping scala-parser-combinators alive longer than necessary.

gourlaysama added a commit that referenced this pull request Sep 29, 2014
Removed JSON deprecation warnings
@gourlaysama gourlaysama merged commit 3ee2e0f into scala:master Sep 29, 2014
@gourlaysama
Copy link
Member

@soc thanks, that makes sense. I never used the JSON implementation...

I agree on the need for a migration guide, I'll look into that (first I need to refresh my understanding of parboiled2).

@propensive propensive deleted the undeprecation branch September 29, 2014 07:22
@soc
Copy link
Member

soc commented Sep 29, 2014

Let's mention @sirthias, so he's aware of what's happening here.

@sirthias
Copy link

Thanks for the ping, Simon!
I still think that parser combinators do serve a purpose as a nice example of how Scala enables elegant and concise solutions to everyday problems (like parsing). I do like the parser combinators implementation.
However, it's true that users should be fully aware of its limitations and especially the runtime performance they can (or cannot) expect.

@SethTisue
Copy link
Member

Was the decision to un-deprecate discussed somewhere, or only on this ticket?

@SethTisue
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants