Rewrote case classes tour #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@heathermiller ready to merge |
julienrf
reviewed
Mar 21, 2017
| case class SMS(sourceNumber: String, message: String) extends Notification | ||
| case class VoiceRecording(contactName: String, link: String) extends Notification | ||
| ``` | ||
| case class Souvenir() |
There was a problem hiding this comment.
I’m not sure this is a good example of case class. We generally use case objects when there are no fields. To me, the purpose of case classes is to aggregate information (in their fields).
There was a problem hiding this comment.
OK I'll change it...
julienrf
reviewed
Mar 21, 2017
|
|
||
| println("SMS is: " + firstSms) | ||
| val message2 = Message("jorge@catalonia.es", "guillaume@quebec.ca", "Com va?") | ||
| val message3 = Message("jorge@catalonia.es", "guillaume@quebec.ca", "Com va?") |
There was a problem hiding this comment.
These examples are excellent!
travissarles
force-pushed
the
case-classes
branch
from
c5c3a1f
to
ce7b008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to keep the concept of case classes simple before moving on to pattern matching. I know there are a few features that I didn't discuss like toString, hashcode, etc. I didn't think they were worth mentioning but feel free to disagree.