SI-8875 showCode should print all class constructor modifiers.

showCode used to print nothing when the only modifier was a change in visibility scope (i.e. no flags but privateWithin is set).
scala · Oct 10, 2014 · 037f295 · 037f295 · scala-jenkins · Oct 10, 2014
1 parent 2b5df37
commit 037f295
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/src/reflect/scala/reflect/internal/Printers.scala b/src/reflect/scala/reflect/internal/Printers.scala
@@ -761,7 +761,7 @@ trait Printers extends api.Printers { self: SymbolTable =>
             val build.SyntacticClassDef(_, _, _, ctorMods, vparamss, earlyDefs, parents, selfType, body) = cl
 
             // constructor's modifier
-            if (ctorMods.hasFlag(AccessFlags)) {
+            if (ctorMods.hasFlag(AccessFlags) || ctorMods.privateWithin != tpnme.EMPTY) {
               print(" ")
               printModifiers(ctorMods, primaryCtorParam = false)
             }

diff --git a/test/files/run/t8875.check b/test/files/run/t8875.check
@@ -0,0 +1 @@
+class Foo private[foo] (bar: Bar)
diff --git a/test/files/run/t8875.scala b/test/files/run/t8875.scala
@@ -0,0 +1,11 @@
+import reflect.runtime.universe._
+
+object Test extends App {
+
+  val name = TermName("foo")
+  val c = q"class Foo private[$name](bar: Bar)"
+
+  // this used to print: "class Foo(bar: Bar)"
+  println(showCode(c))
+
+}