Skip to content

Commit

Permalink
[backport] SI-7497 Use osName startsWith "Mac OS X" ...
Browse files Browse the repository at this point in the history
... instead of `osName contains "OS X"`

See http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-November/005148.html
for the reason why we don't follow developer.apple.com/library/mac/#technotes/tn2002/tn2110.
  • Loading branch information
soc committed May 23, 2013
1 parent dd544d8 commit 325943d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/library/scala/util/Properties.scala
Expand Up @@ -128,8 +128,10 @@ private[scala] trait PropertiesTrait {
/* Some derived values. */
/** Returns `true` iff the underlying operating system is a version of Microsoft Windows. */
def isWin = osName startsWith "Windows"
// See http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-November/005148.html for
// the reason why we don't follow developer.apple.com/library/mac/#technotes/tn2002/tn2110.
/** Returns `true` iff the underlying operating system is a version of Apple Mac OSX. */
def isMac = osName contains "OS X" // See developer.apple.com/library/mac/#technotes/tn2002/tn2110
def isMac = osName startsWith "Mac OS X"

def versionMsg = "Scala %s %s -- %s".format(propCategory, versionString, copyrightString)
def scalaCmd = if (isWin) "scala.bat" else "scala"
Expand Down

3 comments on commit 325943d

@scala-jenkins
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Job pr-rangepos-per-commit failed for 325943d (results):


Took 33 min.
to rebuild, comment "PLS REBUILD/pr-rangepos-per-commit@325943d5c34e4dfc901d589dec6e97f9fcfd1372" on PR 2587

@soc
Copy link
Member Author

@soc soc commented on 325943d May 23, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLS REBUILD ALL!

@soc
Copy link
Member Author

@soc soc commented on 325943d May 23, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[scalacfork] warning: No classes or objects found in package.scala that go in package scala
[scalacfork] prefixes differ: <empty>.scala,scala
[scalacfork] open package module: object runtime
[scalacfork] Exception in thread "main" java.lang.NullPointerException

Didn't we fix this recently?

Please sign in to comment.