Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
removes the assertion in missingHook
In the current synchronization scheme multiple threads can enter the missingHook trying to materialize a package, which hasn't been created. That's fine, because makeScalaPackage, which creates and enters package symbols is synchronized and checks whether the creation is necessary before commencing. Therefore even if makeScalaPackage is called multiple times in rapid succession, the calls will be serialized and all calls except the first one won't do anything.
- Loading branch information
73d079f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Job pr-rangepos-per-commit failed for 73d079f (results):
Took 29 s.
to rebuild, comment "PLS REBUILD/pr-rangepos-per-commit@73d079fb383f82e825c2a40b397b64288e218fe9"on PR #2083