Merge pull request #10452 from som-snytt/revert/string-constrained

Revert aggressive optimization of String lobounds
scala · Jul 3, 2023 · 7c63166 · 7c63166
2 parents dff5007 + 4fd1878
commit 7c63166
Showing 1 changed file with 0 additions and 6 deletions.
diff --git a/src/reflect/scala/reflect/internal/tpe/TypeConstraints.scala b/src/reflect/scala/reflect/internal/tpe/TypeConstraints.scala
@@ -127,18 +127,12 @@ private[internal] trait TypeConstraints {
         case _            => !lobounds.contains(tp)
       }
       if (mustConsider) {
-        def justTwoStrings: Boolean = (
-          tp.typeSymbol == StringClass && tp.isInstanceOf[ConstantType] &&
-          lobounds.lengthCompare(1) == 0 && lobounds.head.typeSymbol == StringClass
-        )
         if (isNumericBound && isNumericValueType(tp)) {
           if (numlo == NoType || isNumericSubType(numlo, tp))
             numlo = tp
           else if (!isNumericSubType(tp, numlo))
             numlo = numericLoBound
         }
-        else if (justTwoStrings)
-          lobounds = tp.widen :: Nil // don't accumulate strings; we know they are not exactly the same bc mustConsider
         else lobounds ::= tp
       }
     }