Avoid warning on setter in trait

The setter can be detected as isVar. Ignore its synthetic parameter.
scala · Sep 23, 2022 · 8b7eedf · 8b7eedf
1 parent 98972e5
commit 8b7eedf
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/compiler/scala/tools/nsc/typechecker/TypeDiagnostics.scala b/src/compiler/scala/tools/nsc/typechecker/TypeDiagnostics.scala
@@ -547,7 +547,7 @@ trait TypeDiagnostics extends splain.SplainDiagnostics {
               if (sym.isPrimaryConstructor)
                 for (cpa <- sym.owner.constrParamAccessors if cpa.isPrivateLocal) params += cpa
               else if (sym.isSynthetic && sym.isImplicit) return
-              else if (!sym.isConstructor && !isTrivial(rhs))
+              else if (!sym.isConstructor && !sym.isVar && !isTrivial(rhs))
                 for (vs <- vparamss) params ++= vs.map(_.symbol)
               defnTrees += m
             case _ =>

diff --git a/test/files/pos/t12646.scala b/test/files/pos/t12646.scala
@@ -0,0 +1,11 @@
+
+// scalac: -Werror -Wunused:params
+
+trait T {
+  private var x: String = _
+
+  def y: String = {
+    if (x eq null) x = "hello, world"
+    x
+  }
+}