-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SI-6956 determine switchability by type, not tree
Constant folding will set the type of a constant tree to `ConstantType(Constant(folded))`, while the tree itself can be many different things (in casu, an Ident). We used to look at the tree directly when deciding whether to emit a switch. Now we look at the tree's type. Voilà.
- Loading branch information
Showing
3 changed files
with
31 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import scala.tools.partest.IcodeTest | ||
|
||
class Switches { | ||
private[this] final val ONE = 1 | ||
|
||
def switchBad(i: Byte): Int = i match { | ||
case ONE => 1 | ||
case 2 => 2 | ||
case 3 => 3 | ||
case _ => 0 | ||
} | ||
|
||
def switchOkay(i: Byte): Int = i match { | ||
case 1 => 1 | ||
case 2 => 2 | ||
case 3 => 3 | ||
case _ => 0 | ||
} | ||
} | ||
|
||
object Test extends IcodeTest { | ||
// ensure we get two switches out of this -- ignore the rest of the output for robustness | ||
// exclude the constant we emit for the "SWITCH ..." string below (we get the icode for all the code you see in this file) | ||
override def show() = println(collectIcode("").filter(x => x.indexOf("SWITCH ...") >= 0 && x.indexOf("CONSTANT(") == -1).size) | ||
} | ||
|