Test case for recently improved unchecked warning #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review by @xeno-by |
| // - implicit class tags to enable type patterns on abstract types | ||
| // - type tests on compound types. | ||
| // | ||
| // We could try make these work together, but an unchecked warning is okay for now. |
There was a problem hiding this comment.
We could generate implicltly[ClassTag].runtimeClass.isInstance(a) && a.isInstanceOf[Bar]
For _: C with D we already generate a.isInstanceOf[C] && a.isInstanceOf[D], but this is done quite late (in erasure), and it would be tricky to integrate that with the classtag based tests, which are added much earlier.
|
ping |
|
checkfile updated |
|
PLS REBUILD/pr-scala@0a9bb1d |
|
LGTM |
ghost
assigned 
|
(kitty-note-to-self: ignore 30060390) |
|
I think this needs to be rebased -- due to the askLoadedType change |
Prior to scala#2848, the enclosed test compiled without warning and printed: true false Features interacting: - implicit class tags to enable type patterns on abstract types - type tests on compound types. I think the unchecked warning is acceptable for now.
|
rebased |
adriaanm
added a commit
that referenced
this pull request
Dec 13, 2013
Test case for recently improved unchecked warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #2848, the enclosed
test compiled without warning and printed:
Features interacting:
I think the unchecked warning is acceptable for now.