Use normal mixed-in Product.productIterator

[som-snytt]

Omit generating the method and acquire the usual
trait implementation. This follows Scala 3.

(The special runtime support was added as an experiment
and never removed when the experiment ended.)

[som-snytt]

Was going to skip deprecating the utility method in ScalaRunTime, but maybe a comment would assist someone cleaning up later in Scala 3.

[joroKr21]

I remember wondering why this method is generated. I guess it's one of those things that everyone assumed there is a good reason when there is none. 👍 maybe delete instead of commenting out?

[som-snytt]

Yes, I meant to comment that I followed local code style in commenting out.

I mentioned on Scala 3 that Scala 3 does _1 components! I didn't try uncommenting that code.

[joroKr21]

Either way I'm in favour of this change

[som-snytt]

I will now follow up by deleting just the rogue iterator that is commented out here. In part to placate @joroKr21

[som-snytt]

I was about to add the deprecation of the runtime method, which we can't delete because of compatibility.

But unbootstrapped build would complain. Yet perhaps I will suppress it.

[warn] .../scala/src/reflect/scala/reflect/internal/Types.scala:1136:15: method typedProductIterator in object ScalaRunTime is deprecated (since 2.13.9): Case classes inherit productIterator
[warn]   case object WildcardType extends ProtoType {

[som-snytt]

I think there should be a chat channel just for -Wconf questions where Lukas gets notifications on his phone.

[lrytz]

👍 LGTM. Thanks to the mixin forwarder, case classes still have a productIterator method in bytecode, so there's no change for the runtime-generated SerialVersionUIDs.

[SethTisue]

MiMA user confused by the effect of this: lightbend-labs/mima#723