Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Avoid retaining refs to previously added items after VectorBuilder.clear #10019

Merged
merged 3 commits into from
May 2, 2022
Merged

[backport] Avoid retaining refs to previously added items after VectorBuilder.clear #10019

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1ccb5c
=col Clear VectorBuilder more.
He-Pin Apr 27, 2022
0e4b401
VectorBuilder clear test
som-snytt May 2, 2022
9ea6291
Reduce warnings
som-snytt May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/library/scala/collection/immutable/Vector.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,11 @@ final class VectorBuilder[A]() extends ReusableBuilder[A, Vector[A]] with Vector
}

def clear(): Unit = {
display5 = null
display4 = null
display3 = null
display2 = null
display1 = null
display0 = new Array[AnyRef](32)
depth = 1
blockIndex = 0
Expand Down