Accept -Vprint:all, -Vprint:~tailcalls
#10173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good |
|
I'll work out the kinks. I think there was a kink. |
som-snytt
force-pushed
the
tweak/vprintem
branch
2 times, most recently
from
6bc1a88
to
b8418ec
Compare
som-snytt
force-pushed
the
tweak/vprintem
branch
from
b8418ec
to
6c8c97b
Compare
|
That was quite finicky. A test failure due to checking "can I log at the phase under construction"? Very metaphysical. Also scala/scala3#17682 in case it is picked up for a spree. The other idea is |
|
Nice! Is it possible to cram doc for the |
|
While cramming, I also added the default I've longed for. Not sure if I created a ticket for it previously or just tweeted about it endlessly. |
SethTisue
changed the title
-Vprint:all, -Vprint:~tailcalls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Scala 3 uses "all", it would be easier if Scala 2 regressed to also accepting all in
-Vprint:all.Often, one wishes to see both incoming and outgoing trees.
It is verbose and cumbersome to determine which phase precedes
tailcalls, for instance, in order to-Vprint:fields,tailcalls.The updated syntax is
-Vprint:~tailcalls.Since settings are not aware of phase order, semantics are the onus of the feature. The syntax is not supported automatically by
-Vshow, for example.Note that id syntax is
-Vprint:12-13and tilde is not supported for id. It is trivial to compute the predecessor of phase 13 (unlucky phase!).~alldoes not mean before and after every phase, i.e., twice.