Under -Xsource:3, adjust 2.13.9 change to ignore override type for whitebox macro expansion
#10188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably the
|
som-snytt
force-pushed
the
issue/12647-more-whitebox
branch
from
d8e6e83
to
8ecb219
Compare
lrytz
approved these changes
Oct 17, 2022
| */ | ||
| private def assignTypeToTree(tree: ValOrDefDef, defnTyper: Typer, pt: Type): Type = { | ||
| val rhsTpe = tree match { | ||
| case ddef: DefDef if tree.symbol.isTermMacro => defnTyper.computeMacroDefType(ddef, pt) | ||
| case ddef: DefDef if tree.symbol.isTermMacro => defnTyper.computeMacroDefType(ddef, pt) // unreached, see methodSig |
There was a problem hiding this comment.
So this can be removed?
There's also a comment in computeMacroDefType saying
if a macro def doesn't have explicitly specified return type, this method will be called again by
assignTypeToTree
is that stale?
There was a problem hiding this comment.
I was reluctant to expand the scope, as macros remain experimental.
|
@lrytz want to press "merge", here? |
SethTisue
changed the title
-Xsource:3, adjust 2.13.10 change to ignore override type for whitebox macro expansion
SethTisue
changed the title
-Xsource:3, adjust 2.13.10 change to ignore override type for whitebox macro expansion-Xsource:3, adjust 2.13.9 change to ignore override type for whitebox macro expansion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the condition for inferring the type of an overriding def under
-Xsource:3: use the precise type of the RHS if the RHS is the expansion of a whitebox macro.Adjusts #9891
Fixes scala/bug#12647