Merge 2.12.x to 2.13.x [ci: last-only] #10233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given
```
public class A {
protected static class AI { }
}
public class B extends A {
public static class BI extends AI { }
}
```
The owner of `AI` is the module class `A$`, the owner of `BI` is the
module class `B$`. When checking if the protected `AI` can be accessed
in `B$`, we need to navigate from `B$` to `B`. The inheritance chain
is not reflected in the module classes.
because doing so runs afoul of typelevel/scalacheck#677
….17.0 Update scalacheck to 1.17.0
the old test code was wrong (in one place it said `Int`, whereas `String` is correct) but apparently the wrapper that ran the test was wrong too, so the test wasn't testing anything happily, the wrapping is no longer needed (as we don't need to check the JDK version -- and if someday we do, we now have better support for that in partest, with `javaVersion`)
…hic-tests fix and expand testing of signature polymorphic methods
…ixups spec and test tweaks for signature polymorphic methods
SethTisue
added
the
internal
|
I'm a user and it's visible to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no user-visible changes here. it's all testing and build stuff
motivation to do the merge now: