Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint for integral divisions that are widened to a float [forward port from 2.12] #10369

Merged
merged 2 commits into from Apr 11, 2023
Merged

Lint for integral divisions that are widened to a float [forward port from 2.12] #10369

merged 2 commits into from Apr 11, 2023

Conversation

som-snytt
Copy link
Contributor

See #10313

@scala-jenkins scala-jenkins added this to the 2.13.12 milestone Apr 8, 2023
@SethTisue SethTisue modified the milestones: 2.13.12, 2.13.11 Apr 8, 2023
@SethTisue SethTisue added the prio:hi high priority (used only by core team, only near release time) label Apr 8, 2023
@som-snytt som-snytt marked this pull request as ready for review April 8, 2023 19:18
@SethTisue SethTisue requested a review from lrytz April 8, 2023 22:10
@SethTisue SethTisue changed the title Forward port widened int div warning Lint for integral divisions that are widened to a float [forward port from 2.12] Apr 8, 2023
lrytz
lrytz approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lrytz lrytz merged commit 146d763 into scala:2.13.x Apr 11, 2023
4 checks passed
@SethTisue SethTisue added release-notes worth highlighting in next release notes and removed prio:hi high priority (used only by core team, only near release time) labels Apr 11, 2023
@som-snytt som-snytt deleted the forward/int-div branch April 11, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz approved these changes

Assignees
No one assigned
Labels
release-notes worth highlighting in next release notes
Projects
None yet
Milestone
2.13.11
4 participants
@som-snytt @lrytz @SethTisue @scala-jenkins