Use URI to compute Scaladoc URI [ci: last-only] #10502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That test seems to succeed trivially, because of course it does. (I tested manually.) |
|
Adjusted the milestone because it is a regression, and because of the terribly important adjustments to imports in the code base. |
som-snytt
force-pushed
the
issue/12846-scaladoc-unicode
branch
from
208ba1f
to
f790c6d
Compare
|
Learned the minimum (barely) about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#12846
toUriwill perform escapes, butURIconstructor will not.Also clean up some imports. Avoid
collection._. Preferraw"".rfor constructing a regex.