Invalidate sources that depends on @inline
methods
#10633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes sbt/sbt#4125, sbt/zinc#537.
Issue
When
@inline
method implementation changes, the public API of@inline
method does not change, hence Zinc does not invalidate sources that depends on@inline
method.Solution
The behaviour of
@inline
method is similar to macro methods. Hence, we can mark@inline
method as macro and reuse existing Zinc invalidation logic for macro invalidation.Validating the fix
Scripted test is added to Zinc side (sbt/zinc#1310). The test passed.
TODOs
@inline
. To handle that case, we need to follow -opt:l:inline breaks incremental compilation sbt/zinc#537 (comment) and drop call-site@inline
at compiler side.@inline
annotation, compiler may still sometimes inline a method. The compiler keep a log of inlined methods, so in a follow up PR, we can utilize that information instead of directly checking@inline
annotation.