In mixed compilation, allow Java sources to reference MODULE$
#10644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/9714-java-names-singleton
branch
from
e8ac5a8
to
26002ec
Compare
lrytz
force-pushed
the
issue/9714-java-names-singleton
branch
from
26002ec
to
9710b52
Compare
SethTisue
changed the title
MODULE$
i10416
added a commit
to i10416/dotty
that referenced
this pull request
Feb 25, 2024
bishabosha
added a commit
to scala/scala3
that referenced
this pull request
Feb 28, 2024
To find Scala companion mudule from Java, we should strip module suffix `$`. This ~provides workaround~ fixes #17255 as well as forward-port scala/scala#10644. ~, but it requires some refinment to fix it because not-fully-qualified type like the following example still fails to compile due to missing symbol.~ Related to scala/scala#10644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java can refer to a Scala object
ModuleasModule$.MODULE$, which is of runtime typeModule$.However, in mixed compilation, Scalac does not understand
Module$as a type written in Java, which isModule.typein Scala. This commit allows Scala to accept the notation in Java sources.Fixes scala/bug#9714