Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent creation of one element HashSetCollision1 #1071

Closed
wants to merge 1 commit into from
Closed

Prevent creation of one element HashSetCollision1 #1071

wants to merge 1 commit into from

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Aug 6, 2012

if there is one element, there is no collision!

A problem with this might be that size for ListSet is O(N), and there is no other way to figure out if a ListSet contains exactly one element. Also, head might not be efficient for ListSet.

But clearly having a HashSetCollision1 with one element is undesirable.

if there is one element, there is no collision!
@scala-jenkins
Copy link

Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/93/

@scala-jenkins
Copy link

Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/796/

@scala-jenkins
Copy link

jenkins job pr-rangepos: Failed - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/93/

@scala-jenkins
Copy link

jenkins job pr-scala-testsuite-linux-opt: Failed - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/796/

@jsuereth
Copy link
Member

jsuereth commented Aug 7, 2012

PLS REBUILD ALL

@scala-jenkins
Copy link

Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/111/

@scala-jenkins
Copy link

Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/815/

@scala-jenkins
Copy link

jenkins job pr-rangepos: Failed - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/111/

@scala-jenkins
Copy link

jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/815/

@jsuereth
Copy link
Member

jsuereth commented Aug 7, 2012

Again, why 2.9.x? We're pushing a 2.10.x release shortly. 2.9.x gets fixes on an as needed basis.

@rklaehn
Copy link
Contributor Author

rklaehn commented Aug 7, 2012

Hi Josh,

sorry, that was a mistake.

On Tue, Aug 7, 2012 at 9:33 PM, Josh Suereth notifications@github.comwrote:

Again, why 2.9.x? We're pushing a 2.10.x release shortly. 2.9.x gets fixes
on an as needed basis.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1071#issuecomment-7564132.

@rklaehn
Copy link
Contributor Author

rklaehn commented Aug 9, 2012

Closing this because it was against 2.9.x. Will open a new one against 2.10.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants