silence some warnings in test code #10748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
added
the
internal
SethTisue
commented
Apr 10, 2024
| @@ -232,13 +232,14 @@ object TermConstructionProps extends QuasiquoteProperties("term construction") { | |||
| object O | |||
| implicit val liftO = Liftable[O.type] { _ => q"foo; bar" } | |||
| assertEqAst(q"f(..$O)", "f(foo, bar)") | |||
| } | |||
| }: @annotation.nowarn("cat=unused-locals") | |||
There was a problem hiding this comment.
@som-snytt seems like a false positive, wdyt?
There was a problem hiding this comment.
that looks familiar but I can't find a ticket.
|
@SethTisue thanks, today I broke down and added those parens. Or no I didn't, I nowarned it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one of them involves a JDK 22 deprecation warning, so it was failing the build now that we've added JDK 22 to the matrix