Restrict fix to Properties #10758
Merged
Restrict fix to Properties #10758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrytz
reviewed
Apr 16, 2024
src/repl-frontend/scala/tools/nsc/interpreter/shell/ShellConfig.scala
Outdated
Show resolved
Hide resolved
som-snytt
force-pushed
the
fix/repl-color-redux
branch
from
00a24f8
to
6997d95
Compare
lrytz
force-pushed
the
fix/repl-color-redux
branch
from
6997d95
to
a064a89
Compare
lrytz
approved these changes
Apr 17, 2024
SethTisue
added
the
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The null arg was wrong, so use idiot-proof idiom instead.
Restore ShellConfig, where the original intervention landed.
haveInteractiveConsoleis used for picking jline reader, so it seems correct to check isConsole.