Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-6644 Account for varargs in extmethod forwarder #1608

Merged
merged 1 commit into from Nov 14, 2012

Conversation

retronym
Copy link
Member

Which sounded difficult, so instead I offshored the work
to the friendly republic of TreeGen.

Review by @paulp for content, @jsuereth for merge target.

It doesn't seem different from the multitude of prior "value classes + X
are broken" bugs that blocked earlier RCs.

Which sounded difficult, so instead I offshored the work
to the friendly republic of TreeGen.
@retronym
Copy link
Member Author

@scala-jenkins
Copy link

Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1610/

@scala-jenkins
Copy link

jenkins job pr-scala-testsuite-linux-opt: Failed - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1610/

@scala-jenkins
Copy link

Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/899/

@scala-jenkins
Copy link

jenkins job pr-rangepos: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/899/

@paulp
Copy link
Contributor

paulp commented Nov 13, 2012

Always a thrill to see someone daring to reuse code. Lgtm.

@paulp
Copy link
Contributor

paulp commented Nov 13, 2012

irony: mkForwarder had zero callers before this commit. So I guess that isn't "reusing code" so much as it is "using code."

@retronym
Copy link
Member Author

Double dose: it was added in that way originally in 2008 (562647a) by the author of the code I updated to use it. Prescient or what!

@jsuereth
Copy link
Member

LGTM

jsuereth added a commit that referenced this pull request Nov 14, 2012
SI-6644 Account for varargs in extmethod forwarder
@jsuereth jsuereth merged commit 49de222 into scala:2.10.0-wip Nov 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants