Skip to content

SI-6644 Account for varargs in extmethod forwarder #1608

Merged
merged 1 commit into from Nov 14, 2012

4 participants

@retronym
The Scala Programming Language member

Which sounded difficult, so instead I offshored the work
to the friendly republic of TreeGen.

Review by @paulp for content, @jsuereth for merge target.

It doesn't seem different from the multitude of prior "value classes + X
are broken" bugs that blocked earlier RCs.

@retronym retronym SI-6644 Account for varargs in extmethod forwarder
Which sounded difficult, so instead I offshored the work
to the friendly republic of TreeGen.
1e0a30a
@paulp
paulp commented Nov 13, 2012

Always a thrill to see someone daring to reuse code. Lgtm.

@paulp
paulp commented Nov 13, 2012

irony: mkForwarder had zero callers before this commit. So I guess that isn't "reusing code" so much as it is "using code."

@retronym
The Scala Programming Language member

Double dose: it was added in that way originally in 2008 (562647a) by the author of the code I updated to use it. Prescient or what!

@jsuereth
The Scala Programming Language member

LGTM

@jsuereth jsuereth merged commit 49de222 into scala:2.10.0-wip Nov 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.