SI-6745 Skip refinements in the search for <init>

[retronym]

These arise in the base class sequence when a self type
is annotated. This prevented an auxillary constructor from
calling the primary constructor.

[retronym]

Review by @adriaanm

[xeno-by]

Why did the error message mention Predef?

[retronym]

Unable to find the primary constructor, it must have continued on to look for <init> in enclosing imports. I suppose we could harden against this in typedIdent and/or Context#importedSymbol.

[paulp]

Even if it doesn't materially alter the outcome, one's confidence in the compiler having some idea what it is doing cannot help but be weakened by messages like "too many arguments for constructor Predef: ()type".

[paulp]

In some apparently uncommitted branch, I have an "isImportableSymbol" which is used in Context and which excludes constructors among other things.

[paulp]

Nope, not unpublished.

    /** Is this symbol unimportable? Unimportable symbols include:
     *  - constructors, because <init> is not a real name
     *  - private[this] members, which cannot be referenced from anywhere else
     *  - members of Any or Object, because every instance will inherit a
     *    definition which supersedes the imported one
     */
    def isUnimportable(sym: Symbol) = (
         (sym eq NoSymbol)
      || sym.isConstructor
      || sym.isPrivateLocal
      || isUniversalMember(sym)
    )
    def isImportable(sym: Symbol) = !isUnimportable(sym)

[paulp]

It seems allImportedSymbols is filtered by the above (because it calls importableMembers) but importedSymbol is not.

[retronym]

This patch is still wrong with a self type other than Any. I'll fix this post haste, and then we should knock off https://issues.scala-lang.org/browse/SI-4460 too.

[scala-jenkins]

Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1069/

[scala-jenkins]

jenkins job pr-rangepos: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1069/

[scala-jenkins]

Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1779/

[scala-jenkins]

jenkins job pr-scala-testsuite-linux-opt: Failed - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1779/

[retronym]

PLS REBUILD pr-scala-testsuite-linux-opt

[scala-jenkins]

Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1838/

[scala-jenkins]

jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1838/

[adriaanm]

i worry the shape of pre and the owner chain of the current enclosing class need not always coincide but can't come up with an example

[adriaanm]

more conceptually, I feel the prefix should've come in typed correctly in the first place
I'll try to come up with a more concrete suggestion after i've made a breadth-first sweep through my other PRs

[retronym]

I really should have restructured things to detect name == nme.CONSTRUCTOR way earlier (https://github.com/retronym/scala/blob/df570f08/src/compiler/scala/tools/nsc/typechecker/Typers.scala#L4820) and then perform this and only this lookup.

[retronym]

Retargetted to master.