New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expunged the .net backend. #1718

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@paulp
Contributor

paulp commented Dec 6, 2012

It lives on in a branch born from this commit's parent.
It's abrupt; no attempt is made to offer a "smooth transition"
for the serious msil userbase, population zero. If anyone feels
very strongly that such a transition is necessary, I will be
happy to talk you into feeling differently.

Expunged the .net backend.
It lives on in a branch born from this commit's parent.
It's abrupt; no attempt is made to offer a "smooth transition"
for the serious msil userbase, population zero. If anyone feels
very strongly that such a transition is necessary, I will be
happy to talk you into feeling differently.
@scala-jenkins

This comment has been minimized.

scala-jenkins commented Dec 6, 2012

@scala-jenkins

This comment has been minimized.

scala-jenkins commented Dec 6, 2012

@scala-jenkins

This comment has been minimized.

scala-jenkins commented Dec 6, 2012

Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1799/

@scala-jenkins

This comment has been minimized.

scala-jenkins commented Dec 6, 2012

jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1799/

@@ -669,9 +667,6 @@ LOCAL REFERENCE BUILD (LOCKER)
<pathelement location="${build-locker.dir}/classes/library"/>
</classpath>
</javac>
<!-- NOTE: Potential problem with maximal command line length on Windows
(32768 characters for XP, since executed with Java's "exec"). See
src/build/msil.xml in msil branch for more details. -->

This comment has been minimized.

@xeno-by

xeno-by Dec 6, 2012

Member

Would be interesting to know where that msil.xml lives to learn about maximal command line length.

This comment has been minimized.

@paulp

paulp Dec 6, 2012

Contributor

91f82d5#L3L168

-    <!--
-        NOTE: Command line length hell on windows. The maximal command line length on
-        Windows XP or later is 8191 characters (http://support.microsoft.com/kb/830473).
-
-        BUT: this only applies for processes executed directly in the shell, which is NOT
-        the case by default when using ant's "exec" command; this one uses the Java VM's
-        execution facilities which allow larger command lines. Testing gives:
-          - Windows XP: 32768 characters
-
-        When the parameter (vmlauncher="false") is specified, the <exec/> command uses
-        the udnerlying shell, and the smaller limit applies.
-
-        The call to ilasm produces lots of output, which could be avoided using
-        (spawn="true"). This seems to work wrt to the character limit (32768), but is
-        probably not the best solution since it's incompatible with (failonerror),
-        and does not produce any output at all.
-    -->

This comment has been minimized.

@xeno-by

xeno-by Dec 6, 2012

Member

I think it will be helpful to add this comment to build.xml.

This comment has been minimized.

@paulp

paulp Dec 6, 2012

Contributor

I started to comply, but stopped when I realized how little of it made sense. Can you maybe reformulate the comment to have some meaning in the context of the build as it is today? Because a) we never use ant's 'exec' task for anything where max command line length could possibly come up and b) ilasm?

This comment has been minimized.

@xeno-by

xeno-by Dec 6, 2012

Member

Yeah you're right. Looks like all execs with non-trivial command lines are done in our custom tasks.

@lrytz

This comment has been minimized.

Member

lrytz commented Dec 6, 2012

let me shed a tear. 😿

@JamesIry

This comment has been minimized.

Contributor

JamesIry commented Dec 6, 2012

lgtm. Expect some minor merge conflicts with my excision of the GenJVM backend.

@paulp

This comment has been minimized.

Contributor

paulp commented Dec 6, 2012

There, there, sad kitty. There, there.

@adriaanm

This comment has been minimized.

Member

adriaanm commented Dec 6, 2012

uh-oh, I seem to already have merged this into oblivion -- let's wait until #1717 is merged, rebase this one and merge it before it gets another chance to go all stale on us

@paulp

This comment has been minimized.

Contributor

paulp commented Dec 6, 2012

Superseded by #1724.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment