SI-6187 Make partial functions re-typable #2011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Sigh... |
- `New(tpe)` doesn't survive a `resetAttrs` / typecheck; use a name instead. - Abandon the tree attachment that passed the default case from `typer` to `patmat`; this tree eluded the attribute reset performed in the macro. Instead, add it to the match. Apart from making the tree re-typable, it also exposes the true code structure to macros, which is important if they need to perform other code transformations. - Install original trees on the declared types of the parameters of the `applyOrElse` method to ensure that references to them within the method pick up the correct type parameter skolems upon retypechecking. - Propagate `TypeTree#original` through `copyAttrs`, which is called during tree duplication / `TreeCopiers`. Without this, the original trees that we installed were not visible anymore during `ResetAttrs`. We are not able to reify partial functions yet -- the particular sticking point is reification of the parentage which is only available in the `ClassInfoType`.
| @@ -2706,7 +2709,7 @@ trait Typers extends Modes with Adaptations with Tags { | |||
| val x = mkParam(methodSym, A1.tpe) | |||
|
|
|||
| // applyOrElse's default parameter: | |||
| val B1 = methodSym newTypeParameter (newTypeName("B1")) setInfo TypeBounds.empty //lower(resTp) | |||
| val B1 = methodSym newTypeParameter (newTypeName("B1")) setInfo TypeBounds.empty | |||
There was a problem hiding this comment.
Looking at this again, I see that comment was succinctly noting that this type will be patched a few lines below.
B1 setInfo TypeBounds.lower(matchResTp) // patch info
|
BUILDLOG? |
|
(kitty-note-to-self: ignore 13201539) pr-checkin-per-commit: |
|
Unfortunately, I know close to nothing about patmat, so I don't feel entitled for rubberstamping here |
|
rebasing and reviewing |
This was referenced Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New(tpe)doesn't survive aresetAttrs/ typecheck; usea name instead.
case from
typertopatmat; this tree eluded theattribute reset performed in the macro. Instead, add it
to the match. Apart from making the tree re-typable, it
also exposes the true code structure to macros, which
is important if they need to perform other code
transformations.
parameters of the
applyOrElsemethod to ensure thatreferences to them within the method pick up the correct
type parameter skolems upon retypechecking.
TypeTree#originalthroughcopyAttrs,which is called during tree duplication /
TreeCopiers.Without this, the original trees that we installed were
not visible anymore during
ResetAttrs.We are not able to reify partial functions yet -- the
particular sticking point is reification of the parentage
which is only available in the
ClassInfoType.Review by @adriaanm / @xeno-by
I'm using
typedCasenow, based on your prior review. TheasInstanceOfis also gone.