SI-7247, deprecate NotNull. #2244
Conversation
| def notNull: Type = | ||
| if (!settings.Ynotnull.value || isNotNull || phase.erasedTypes) this | ||
| else NotNullType(this) | ||
| @deprecated("This method will be removed", "2.11.0") def notNull: Type = this |
There was a problem hiding this comment.
we're in reflect.internal -- we can probably get rid of this as well
There was a problem hiding this comment.
Would be glad to dump it, but I'm always breaking the IDE and I figured a one line identity function was cheap insurance.
|
Great. I almost finished cobbling together my own PR when I checked email and saw this. This LBTM (think "better", not "lobotomy") once we prune those last unused things, unless they are used? |
|
Will rebase/remove/reopen. |
It never worked and it would periodically jump out and bite someone. Slash and burn so new plants can take root. Eliminated NotNullType and NotNullClass, internal elements. Removed notNull method on Type, which no longer has a purpose. Retained 'def isNotNull' because there are types which are known by construction not to be null (ThisType, ConstantType as long as the constant isn't null, etc.) and that's still useful to know.
Maybe this was useful in some way; but no way I ever saw. I have comments which tell me this is exposed in the IDE so I left a stub. I also removed mkCheckInit. That probably sounds like it's related to -Xcheckinit. Guess again, guy-who-thinks-names-mean-things. It was only used by -Xcheck-null.
Removed NotNull from tests and the parentage of AnyVal. Removed the tests which were actually testing anything to do with NotNull; massaged the others to forget NotNull and/or not to name local things NotNull.
Restarted the Zamboni and collected these as well. Author was convinced by reviewer that clinging to isNotNull like Linus's security blanket will not help us with landing a picture of the Great Pumpkin. YAGNI, Charlie Brown.
This was a little trickier than the previous. I introduced a new method 'isBottomSubClass' which is the obvious complement to the beloved 'isNonBottomSubClass'. In eliminating the two call sites of containsNull I might have overshot the mark a bit when I rewrote fourthTry and thirdTryRef, but who is going to argue with such beauty as this.
|
Okay @adriaanm this should now be worthy of your attention. |
|
I hope so. |
ghost
assigned
|
@adriaanm, perhaps it's time for YOU to try to be worthy of IT. Too busy making smoothies, I bet. |
|
LGTM |
|
Great JIRA is "temporarily unavailable" (I wish it was permanent). Ticket still needs to be closed. |
|
i started it again |
|
If I properly get it, if a value whose type is currently marked with this trait is given a What will replacement for such case, either for scala-lib type (e.g. |
|
NotNull only worked in trivial cases and it proved hard to extend it beyond On Saturday, March 15, 2014, cchantep notifications@github.com wrote:
|
|
I can understand, but that's a quite radical pov. |
These rules were removed in scala#2244 and scala.NotNull itself was deprecated.
Brought the steamroller to bear on NotNull; fired up the Zamboni afterward to smooth things over.