cleanup of old stuff from the GenJVM era #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once comment about magic number is added this is good to go. I know that the comment wasn't there before and the magic number was but since we are touching this piece of code it would be good to document it. Also, it would be good to explain what |
|
A second opinion is welcome, but looks like the Looks Good conditions have been met. |
|
LGTM2. |
paulp
added a commit
that referenced
this pull request
Apr 26, 2013
cleanup of old stuff from the GenJVM era
|
LGTM. Thanks a lot for the comment! I learnt something from it, actually. 👍 |
eed3si9n
pushed a commit
to eed3si9n/scala
that referenced
this pull request
May 14, 2019
For example, when the `--sourcepath` option is provided and the refchecks phase compiles an annotation found on a referenced symbol from the sourcepath. `compileLate` assumes that all non-sentinel compiler phases can be down cast to `GlobalPhase`. This commit changes the two phases in SBT to extend this instead of `Phase`. This has the knock on benefit of simplifying the phases by letting the `GlobalPhase.run` iterator over the list of compilation units and feed them to us one by one. I checked that the test case failed before making each change.
eed3si9n
pushed a commit
to eed3si9n/scala
that referenced
this pull request
May 14, 2019
For example, when the `--sourcepath` option is provided and the refchecks phase compiles an annotation found on a referenced symbol from the sourcepath. `compileLate` assumes that all non-sentinel compiler phases can be down cast to `GlobalPhase`. This commit changes the two phases in SBT to extend this instead of `Phase`. This has the knock on benefit of simplifying the phases by letting the `GlobalPhase.run` iterator over the list of compilation units and feed them to us one by one. I checked that the test case failed before making each change.
eed3si9n
added a commit
to eed3si9n/scala
that referenced
this pull request
May 14, 2019
FPORT: Avoid CCE when scalac internally uses compileLate. Fixes scala#2452
lrytz
pushed a commit
to lrytz/scala
that referenced
this pull request
Nov 5, 2019
For example, when the `--sourcepath` option is provided and the refchecks phase compiles an annotation found on a referenced symbol from the sourcepath. `compileLate` assumes that all non-sentinel compiler phases can be down cast to `GlobalPhase`. This commit changes the two phases in SBT to extend this instead of `Phase`. This has the knock on benefit of simplifying the phases by letting the `GlobalPhase.run` iterator over the list of compilation units and feed them to us one by one. I checked that the test case failed before making each change. Rewritten from sbt/zinc@2f9a27f
lrytz
pushed a commit
to lrytz/scala
that referenced
this pull request
Nov 5, 2019
For example, when the `--sourcepath` option is provided and the refchecks phase compiles an annotation found on a referenced symbol from the sourcepath. `compileLate` assumes that all non-sentinel compiler phases can be down cast to `GlobalPhase`. This commit changes the two phases in SBT to extend this instead of `Phase`. This has the knock on benefit of simplifying the phases by letting the `GlobalPhase.run` iterator over the list of compilation units and feed them to us one by one. I checked that the test case failed before making each change. Rewritten from sbt/zinc@a27be44
lrytz
pushed a commit
to lrytz/scala
that referenced
this pull request
Nov 5, 2019
FPORT: Avoid CCE when scalac internally uses compileLate. Fixes scala#2452 Rewritten from sbt/zinc@d0d97f4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review by @JamesIry or @gkossakowski