New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SI-6899, prohibit dangerous, useless implicit conversions. #2625
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,7 @@ | ||
t4158.scala:3: error: type mismatch; | ||
found : Null(null) | ||
required: Int | ||
Note that implicit conversions are not applicable because they are ambiguous: | ||
both method Integer2intNullConflict in class LowPriorityImplicits of type (x: Null)Int | ||
and method Integer2int in object Predef of type (x: Integer)Int | ||
are possible conversion functions from Null(null) to Int | ||
t4158.scala:3: error: an expression of type Null is ineligible for implicit conversion | ||
var y = null: Int | ||
^ | ||
t4158.scala:2: error: type mismatch; | ||
found : Null(null) | ||
required: Int | ||
Note that implicit conversions are not applicable because they are ambiguous: | ||
both method Integer2intNullConflict in class LowPriorityImplicits of type (x: Null)Int | ||
and method Integer2int in object Predef of type (x: Integer)Int | ||
are possible conversion functions from Null(null) to Int | ||
t4158.scala:2: error: an expression of type Null is ineligible for implicit conversion | ||
var x: Int = null | ||
^ | ||
two errors found |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
t6889.scala:16: error: the result type of an implicit conversion must be more specific than AnyRef | ||
def f(x: Dingo): AnyRef = x // fail - no conversion to AnyRef | ||
^ | ||
t6889.scala:17: error: an expression of type Null is ineligible for implicit conversion | ||
var x: Int = null // fail - no conversion from Null | ||
^ | ||
two errors found |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package bippy { | ||
trait Bippy[A] extends Any | ||
} | ||
package foo { | ||
package object unrelated { | ||
implicit def bippyDingo[A](x: bippy.Bippy[A]): AnyRef = Nil | ||
} | ||
package unrelated { | ||
trait Unrelated | ||
} | ||
} | ||
|
||
object Test { | ||
trait Dingo extends Any with bippy.Bippy[foo.unrelated.Unrelated] | ||
|
||
def f(x: Dingo): AnyRef = x // fail - no conversion to AnyRef | ||
var x: Int = null // fail - no conversion from Null | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about reformulating this in a bit lighter manner, e.g.
nulls are ineligible for implicit conversion
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find that misleading, because they're not, and not everything being prohibited here is a null.