Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint-like fixes found by Semmle #2693

Merged
merged 5 commits into from Jul 1, 2013
Merged

Conversation

lexspoon
Copy link
Contributor

No description provided.

@lexspoon
Copy link
Contributor Author

I played around with Semmle's whole-program code scanner on the Scala
repository, and I found a few lint-like issues that seem worth
cleaning up. These queries are fun in that they aren't limited to the files
available in any single compilation run. For example, they can find unsealed
case class hierarchies that aren't extended in another file.

@adriaanm
Copy link
Contributor

LGTM, thanks!

@soc
Copy link
Member

soc commented Jun 29, 2013

LGTM!

@scala-jenkins
Copy link

IDE validation running at https://scala-webapps.epfl.ch/jenkins/job/pr-scala/36/

@scala-jenkins
Copy link

IDE validation running at https://scala-webapps.epfl.ch/jenkins/job/pr-scala/37/

@scala-jenkins
Copy link

IDE validation running at https://scala-webapps.epfl.ch/jenkins/job/pr-scala/38/

@scala-jenkins
Copy link

IDE validation running at https://scala-webapps.epfl.ch/jenkins/job/pr-scala/39/

@scala-jenkins
Copy link

IDE validation running at https://scala-webapps.epfl.ch/jenkins/job/pr-scala/40/

@adriaanm
Copy link
Contributor

adriaanm commented Jul 1, 2013

Conclusion: IDE still compiles, so good to merge.

adriaanm added a commit that referenced this pull request Jul 1, 2013
Lint-like fixes found by Semmle
@adriaanm adriaanm merged commit c1451cf into scala:master Jul 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants