Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Lint-like fixes found by Semmle #2693

Merged
merged 5 commits into from Jul 1, 2013

Conversation

Projects
None yet
4 participants
Contributor

lexspoon commented Jun 28, 2013

No description provided.

Contributor

lexspoon commented Jun 28, 2013

I played around with Semmle's whole-program code scanner on the Scala
repository, and I found a few lint-like issues that seem worth
cleaning up. These queries are fun in that they aren't limited to the files
available in any single compilation run. For example, they can find unsealed
case class hierarchies that aren't extended in another file.

Owner

adriaanm commented Jun 28, 2013

LGTM, thanks!

Member

soc commented Jun 29, 2013

LGTM!

Owner

adriaanm commented Jul 1, 2013

Conclusion: IDE still compiles, so good to merge.

@adriaanm adriaanm added a commit that referenced this pull request Jul 1, 2013

@adriaanm adriaanm Merge pull request #2693 from lexspoon/semmle-lint
Lint-like fixes found by Semmle
c1451cf

@adriaanm adriaanm merged commit c1451cf into scala:master Jul 1, 2013

1 check passed

default pr-rangepos-per-commit Took 53 min.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment