Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-5045 - allow for using Regex without implicit anchors #273

Closed
wants to merge 1 commit into from

Conversation

LannyRipple
Copy link

Code changes to address SI-5045 (https://issues.scala-lang.org/browse/SI-5045)

  • Add trait NoImplictAnchors to override Regex.unapplySeq
  • Add .qr method to StringLike to create a Regex with NoImplicitAnchors
  • Add tests of above

Have discussed in jira, scala-debate, and plan to raise the suggested change on scala-language.

@paulp
Copy link
Contributor

paulp commented Apr 2, 2012

Can you verify you have signed and submitted the contributor agreement at http://www.scala-lang.org/sites/default/files/contributor_agreement.pdf ?

@LannyRipple
Copy link
Author

I'm sure I have not done so yet. Will sign the PDF and mail it in.

-ljr

On Apr 2, 2012, at 11:11 AM, Paul Phillips wrote:

Can you verify you have signed and submitted the contributor agreement at http://www.scala-lang.org/sites/default/files/contributor_agreement.pdf ?


Reply to this email directly or view it on GitHub:
#273 (comment)

@LannyRipple
Copy link
Author

Ok. I have emailed a signed PDF to Danielle.

-ljr

On Apr 2, 2012, at 1:07 PM, Lanny Ripple wrote:

I'm sure I have not done so yet. Will sign the PDF and mail it in.

-ljr

On Apr 2, 2012, at 11:11 AM, Paul Phillips wrote:

Can you verify you have signed and submitted the contributor agreement at http://www.scala-lang.org/sites/default/files/contributor_agreement.pdf ?


Reply to this email directly or view it on GitHub:
#273 (comment)

@scala-jenkins
Copy link

jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/12/

@paulp
Copy link
Contributor

paulp commented May 3, 2012

I incorporated this in a modified form, thanks a lot.

@paulp paulp closed this May 3, 2012
szeiger pushed a commit to szeiger/scala that referenced this pull request Mar 20, 2018
A collection of smaller changes from my integration branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants