New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SI-7901 Bump module versions. #3023
Conversation
Upgrade to the latest releases of modules. This fixes OSGi clients, since previous module releases don't have correct MANIFEST files.
@jsuereth is looking into why dbuild fails to build sbt with this PR. |
So, it looks like typesafehub/sbt-builds-for-ide#12 is merged, we'd need to trigger a rebuild here. |
PLS REBUILD/pr-scala@de1b1d8 |
(kitty-note-to-self: ignore 25903162) |
ping @jsuereth, @dragos, @gkossakowski, @cunei |
@adriaanm, how do you normally bump these versions? Is my assumption correct that once new versions of modules have been published, master can depend on them? I'm not sure what I can do here, other than close it if that's not the right way, but I'd be interested to know what's the normal procedure. |
yes, as soon as they are published, we should bump the versions in this file. |
My understanding was that this was blocked because the sbt-republish job had hard-coded versions, rather than parsing versions.properties. (E.g., https://github.com/typesafehub/sbt-builds-for-ide/blob/master/sbt-on-2.11.x#L6 should be derived from this properties file, which is available during PR validation.) |
Thanks, I didn't realize it was still hard-coded. I thought |
PLS REBUILD ALL |
(kitty-note-to-self: ignore 26795252) |
PLS REBUILD ALL |
(kitty-note-to-self: ignore 28083817) |
Versions have been bumped a bit more since. I'll submit a new PR with the most recent ones ASAP. |
Upgrade to the latest releases of modules. This fixes OSGi
clients, since previous module releases don't have correct
MANIFEST files.
For consistency, I bumped the partest version as well.