Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-7901 Bump module versions. #3023

Closed
wants to merge 1 commit into from

Conversation

dragos
Copy link
Contributor

@dragos dragos commented Oct 8, 2013

Upgrade to the latest releases of modules. This fixes OSGi
clients, since previous module releases don't have correct
MANIFEST files.

For consistency, I bumped the partest version as well.

Upgrade to the latest releases of modules. This fixes OSGi
clients, since previous module releases don't have correct
MANIFEST files.
@dragos
Copy link
Contributor Author

dragos commented Oct 8, 2013

@jsuereth is looking into why dbuild fails to build sbt with this PR.

@dragos
Copy link
Contributor Author

dragos commented Oct 8, 2013

So, it looks like typesafehub/sbt-builds-for-ide#12 is merged, we'd need to trigger a rebuild here.

@dragos
Copy link
Contributor Author

dragos commented Oct 8, 2013

PLS REBUILD/pr-scala@de1b1d8

@scala-jenkins
Copy link

(kitty-note-to-self: ignore 25903162)
🐱 Roger! Rebuilding pr-scala for de1b1d8. 🚨

@adriaanm
Copy link
Contributor

ping @jsuereth, @dragos, @gkossakowski, @cunei

@dragos
Copy link
Contributor Author

dragos commented Oct 18, 2013

@adriaanm, how do you normally bump these versions? Is my assumption correct that once new versions of modules have been published, master can depend on them? I'm not sure what I can do here, other than close it if that's not the right way, but I'd be interested to know what's the normal procedure.

@adriaanm
Copy link
Contributor

yes, as soon as they are published, we should bump the versions in this file.

@adriaanm
Copy link
Contributor

My understanding was that this was blocked because the sbt-republish job had hard-coded versions, rather than parsing versions.properties. (E.g., https://github.com/typesafehub/sbt-builds-for-ide/blob/master/sbt-on-2.11.x#L6 should be derived from this properties file, which is available during PR validation.)

@dragos
Copy link
Contributor Author

dragos commented Oct 18, 2013

Thanks, I didn't realize it was still hard-coded. I thought versions.properties was already used (and the reason why a lot of PRs used to fail, needing a rebase on top of Scala master when this file was added). /cc @jsuereth

@gkossakowski
Copy link
Member

PLS REBUILD ALL

@scala-jenkins
Copy link

(kitty-note-to-self: ignore 26795252)
🐱 Roger! Rebuilding pr-scala for de1b1d8. 🚨

@JamesIry
Copy link
Contributor

JamesIry commented Nov 8, 2013

PLS REBUILD ALL

@scala-jenkins
Copy link

(kitty-note-to-self: ignore 28083817)
🐱 Roger! Rebuilding pr-scala for de1b1d8. 🚨

@adriaanm
Copy link
Contributor

adriaanm commented Nov 8, 2013

Versions have been bumped a bit more since. I'll submit a new PR with the most recent ones ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants