Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(master) codifies the state of the art wrt SI-8104 #3311

Merged

Conversation

xeno-by
Copy link
Member

@xeno-by xeno-by commented Dec 27, 2013

As it was discovered in SI-8104, whiteboxity doesn’t apply equally to
type parameters and type members of materialized type classes.

During implicit search and subsequent type inference, whitebox type parameters
are consistently erased to wildcards, whereas whitebox type members sometimes
remain as is and get in the way of signature conformance checks.

@ghost ghost assigned retronym Dec 27, 2013
@xeno-by
Copy link
Member Author

xeno-by commented Dec 27, 2013

review @retronym

@xeno-by
Copy link
Member Author

xeno-by commented Dec 27, 2013

/cc @milessabin

@retronym
Copy link
Member

Could you add a comment into the neg test to mention that it the test breaks, it might be a progression? People might not immediately, find the associated commit message.

@xeno-by
Copy link
Member Author

xeno-by commented Dec 28, 2013

@retronym Done

@retronym
Copy link
Member

LGTM

As it was discovered in SI-8104, whiteboxity doesn’t apply equally to
type parameters and type members of materialized type classes.

During implicit search and subsequent type inference, whitebox type parameters
are consistently erased to wildcards, whereas whitebox type members sometimes
remain as is and get in the way of signature conformance checks.
xeno-by added a commit that referenced this pull request Dec 29, 2013
…y-master

(master) codifies the state of the art wrt SI-8104
@xeno-by xeno-by merged commit 6834cc2 into scala:master Dec 29, 2013
@xeno-by xeno-by deleted the topic/fine-points-of-whiteboxity-master branch December 30, 2013 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants