SI-7933 REPL javax.script eval is cached result #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def eval(reader: java.io.Reader, context: ScriptContext): Object = compile(reader).eval(context) | ||
| def eval(reader: java.io.Reader, context: ScriptContext): Object = eval(reader: String, context) | ||
|
|
||
| implicit def reader2string(reader: java.io.Reader) = { |
There was a problem hiding this comment.
Maybe we could move this next to scala.tools.nsc.util.stringFromWriter?
|
please update the commit message with a short description of what the problem was and how it's solved |
ghost
assigned 
The problem is that the repl underneath the script engine evaluates input to val res0..resN, so it is a one shot operation. To allow repetition, compile(script) now returns a CompiledScript object whose eval method can be called any number of times.
|
Thanks for clarifying, but I still have some questions. If so, I'm not sure we want to take that hit. Is there a way to only do this wrapping in CompiledScript when running in ScriptEngine mode? |
|
Adriaan, |
|
Ok, sorry, I'm a bit new to the repl code base. |
adriaanm
added a commit
that referenced
this pull request
Feb 10, 2014
SI-7933 REPL javax.script eval is cached result
This was referenced Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.