Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SI-5900 Fix pattern inference regression #3523

Merged
merged 2 commits into from
Feb 13, 2014
Merged

SI-5900 Fix pattern inference regression #3523

merged 2 commits into from
Feb 13, 2014

Commits on Feb 13, 2014

  1. SI-5900 Pending test to show that SI-7886 persists 

        qbin/scalac test/pending/neg/t7886b.scala && qbin/scala Test
    java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.String
        at Test$$anon$1.accept(t7886b.scala:15)
        at Test$.g(t7886b.scala:9)
    @retronym @adriaanm
    retronym authored and adriaanm committed Feb 13, 2014
    Configuration menu
    Copy the full SHA
    b4e1a30 View commit details
    Browse the repository at this point in the history

  2. SI-5900 Fix pattern inference regression 

    This commit does not close SI-5900. It only addresses a regression
in 2.11 prereleases caused by SI-7886.

The fix for SI-7886 was incomplete (as shown by the last commit)
and incorrect (as shown by the regression in pos/t5900a.scala and
the fact it ended up inferring type parameters.)

I believe that the key to fixing this problem will be unifying
the inference of case class constructor patterns and extractor
patterns.

I've explored that idea:

  https://gist.github.com/retronym/7704153
  https://github.com/retronym/scala/compare/ticket/5900

But didn't quite get there.
    @retronym @adriaanm
    retronym authored and adriaanm committed Feb 13, 2014
    1 Configuration menu
    Copy the full SHA
    c956a27 View commit details
    Browse the repository at this point in the history