SI-8385 make sure $quasiquote$tuple gets reified properly #3611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously due to greediness of SyntacticApplied there was a chance that quasiquote tuple placeholder got reified as its representation rather than its meaning.
| // rest will always be non-empty due to the fact that every single-parens | ||
| // application will be reified by reifyTreePlaceholder before it gets here. | ||
| case SyntacticApplied(id @ Ident(nme.QUASIQUOTE_TUPLE), first :: rest) => | ||
| mirrorBuildCall(nme.SyntacticApplied, reifyTreePlaceholder(Apply(id, first)), reify(rest)) |
There was a problem hiding this comment.
Would it be possible to put the fix next to TuplePlaceholder, so that all placeholders are processed next to each other? Or even better - maybe it's possible to even integrate the fix into TuplePlaceholder?
There was a problem hiding this comment.
It's possible to put it into reifyTreePlaceholder but not into TuplePlaceholder as it doesn't do any reification, just wrapping/unwrapping.
|
Also could we hack up other placeholders in the same way, something like |
|
@xeno-by Probably not, as |
|
LGTM then |
adriaanm
added a commit
that referenced
this pull request
Mar 10, 2014
SI-8385 make sure $quasiquote$tuple gets reified properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously due to greediness of SyntacticApplied there was a chance that
quasiquote tuple placeholder got reified as its representation rather
than its meaning.
review @retronym